Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Feb 2020 09:10:06 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Shen Kai <shenkai8@huawei.com>
Cc:     jslaby@suse.com, linux-kernel@vger.kernel.org,
        hushiyuan@huawei.com, linfeilong@huawei.com
Subject: Re: [PATCH] add lock proctect to __handle_sysrq in
 write_sysrq_trigger
Message-ID: <20200207081006.GB309560@kroah.com>
References: <1581062166-27284-1-git-send-email-shenkai8@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1581062166-27284-1-git-send-email-shenkai8@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 07, 2020 at 07:56:06AM +0000, Shen Kai wrote:
> From: Feilong Lin <linfeilong@huawei.com>
> 
> Add lock protect to __handle_sysrq to avoid race condition.
> __handle_sysrq will change console_loglevel without lock protect
> which can lead to console_loglevel to be set as an unexpected value.
> 
> Problem may occur when "echo t > /proc/sysrq-trigger" is called on 
> multiple cpus concurrently.
> 
> In this case in __handle_sysrq, console_loglevel is set to 7 to print
> some head info to the console then restore it. But without lock protect
> in parallel execution situation, restoring may go wrong. The new 
> loglevel may be taken as the previous loglevel incorrectly.
> Console_loglevel can be 7 at last, which causes the terminal to output
> info in most log levels.
> 
> This bug was found on linux 4.19
> 
> Signed-off-by: Feilong Lin <linfeilong@huawei.com>
> Reported-by: Kai Shen <shenkai8@huawei.com>
> ---
>  drivers/tty/sysrq.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index f724962..cbb48a9 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -1087,6 +1087,8 @@ EXPORT_SYMBOL(unregister_sysrq_key);
>  /*
>   * writing 'C' to /proc/sysrq-trigger is like sysrq-C
>   */
> +static DEFINE_MUTEX(sysrq_mutex);
> +
>  static ssize_t write_sysrq_trigger(struct file *file, const char __user *buf,
>  				   size_t count, loff_t *ppos)
>  {
> @@ -1095,7 +1097,9 @@ static ssize_t write_sysrq_trigger(struct file *file, const char __user *buf,
>  
>  		if (get_user(c, buf))
>  			return -EFAULT;
> +		mutex_lock(&sysrq_mutex);
>  		__handle_sysrq(c, false);
> +		mutex_unlock(&sysrq_mutex);

What exactly are you protecting here?  What other task is doing this at
the same exact time?

You mention different tasks hitting this sysrq-trigger at the same time,
but really, "just do not do that" should be the real answer, as even
with this lock, you don't know what the end result will be as the "last"
one in will have the last word, right?

thanks,

greg k-h