Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp344440ybv; Fri, 7 Feb 2020 00:15:00 -0800 (PST) X-Google-Smtp-Source: APXvYqw6vD0ex4kQZ8nGfmNSD2IoTZkTDSh8fPNgMjSjp2S+6gEuC8+nE0J1UlMTA1X/Vy15eN4x X-Received: by 2002:a05:6830:138b:: with SMTP id d11mr1691419otq.38.1581063300571; Fri, 07 Feb 2020 00:15:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581063300; cv=none; d=google.com; s=arc-20160816; b=PJASILgxtsbSTCBYkByjoc+oo+GJpA3OedCEfAWqljbeN/Kr+f1lNrREM9iHTTrB2A e7fJaOSYOdp+yApzMixSxeLjA/xMjpsxVVj1HH3joEsv1JTR2XZjL+bMwyi3V327Adn5 td5w9FeEAT2yDGwwmu1Yr/Rpb+QsBTN6oVvV1OA/DA6JCmydaiJ0R7ohr/mEIKDL/FXf Z7zChPektqsDos7Ax61Fck5QpfqK22vll7oQREHonXGDn8WoeL48s0nQtZgzjChAD5yo XS3AuQmeSxgqW8Ee8Fda3v77AtEfqZUr7auRiZ7e0SAaA+Ktr9zXk9GWLNfUpnUR7YNr LL5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=gWFC//TNNB/D2+Phv+0+dqMT7JGnzLqxrzTUM4R/vJo=; b=rF/92IAt/SCjkxYmO1Z24cH5MMzPHkRwgSUkw4sU5qagCN3pvEiuHBStf7EX05l8vf VbvqnrtqHUu6PZxzDYOigEBaD0yDYse/lra2k3Gc0mawktAyf8CwYBfWXo+zMp8g78J1 eZL5S99iBfVFh/Ze1LxNIkqGZ+d2P+YtpWtiwNjgwl4fe/yBCO+8f4fqet9Vhc2A3RF3 mpNxbJZhMsGcNuCG1UEt4ImE0QnXLXbkrTxRs02yiC+9qe5anf9JC9eEcvXN+vC4vTzL hWByAvhKIltengZGY+wQKhjgx0mlqyBoMxMgYRVFqBCE1qx46pxla1soLFrKe2Qi6h8h p9tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w9si1364523otl.138.2020.02.07.00.14.49; Fri, 07 Feb 2020 00:15:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbgBGINo (ORCPT + 99 others); Fri, 7 Feb 2020 03:13:44 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49810 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726816AbgBGINn (ORCPT ); Fri, 7 Feb 2020 03:13:43 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tomeu) with ESMTPSA id 736D92959E5 Subject: Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) To: Nicolas Boichat Cc: Rob Herring , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , Devicetree List , lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson References: <20200207052627.130118-1-drinkcat@chromium.org> <5237381b-c232-7087-a3d6-78d6358d80bf@collabora.com> From: Tomeu Vizoso Message-ID: <93aec9ae-00fc-bf55-1d6c-9bd715b78344@collabora.com> Date: Fri, 7 Feb 2020 09:13:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/20 8:42 AM, Nicolas Boichat wrote: > On Fri, Feb 7, 2020 at 2:18 PM Tomeu Vizoso wrote: >> >> On 2/7/20 6:26 AM, Nicolas Boichat wrote: >>> Hi! >>> >>> Follow-up on the v3: https://patchwork.kernel.org/cover/11331343/. >>> >>> The main purpose of this series is to upstream the dts change and the >>> binding document, but I wanted to see how far I could probe the GPU, to >>> check that the binding is indeed correct. The rest of the patches are >>> RFC/work-in-progress, but I think some of them could already be picked up. >>> >>> So this is tested on MT8183 with a chromeos-4.19 kernel, and a ton of >>> backports to get the latest panfrost driver (I should probably try on >>> linux-next at some point but this was the path of least resistance). >>> >>> I tested it as a module as it's more challenging (originally probing would >>> work built-in, on boot, but not as a module, as I didn't have the power >>> domain changes, and all power domains are on by default during boot). >>> >>> Probing logs looks like this, currently. They look sane. >>> [ 501.319728] panfrost 13040000.gpu: clock rate = 511999970 >>> [ 501.320041] panfrost 13040000.gpu: Linked as a consumer to regulator.14 >>> [ 501.320102] panfrost 13040000.gpu: Linked as a consumer to regulator.31 >>> [ 501.320651] panfrost 13040000.gpu: Linked as a consumer to genpd:0:13040000.gpu >>> [ 501.320954] panfrost 13040000.gpu: Linked as a consumer to genpd:1:13040000.gpu >>> [ 501.321062] panfrost 13040000.gpu: Linked as a consumer to genpd:2:13040000.gpu >>> [ 501.321734] panfrost 13040000.gpu: mali-g72 id 0x6221 major 0x0 minor 0x3 status 0x0 >>> [ 501.321741] panfrost 13040000.gpu: features: 00000000,13de77ff, issues: 00000000,00000400 >>> [ 501.321747] panfrost 13040000.gpu: Features: L2:0x07120206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xff JS:0x7 >>> [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 >>> [ 501.324951] [drm] Initialized panfrost 1.1.0 20180908 for 13040000.gpu on minor 2 >>> >>> Some more changes are still required to get devfreq working, and of course >>> I do not have a userspace driver to test this with. >> >> Have you tried the Panfrost tests in IGT? They are atm quite basic, but >> could be interesting to check that the different HW units are correctly >> powered on. > > I haven't, you mean this right? > https://gitlab.freedesktop.org/tomeu/igt-gpu-tools/tree/panfrost Yes, though may be better to use the upstream repo: https://gitlab.freedesktop.org/drm/igt-gpu-tools > Any specific test you have in mind? All the panfrost ones, but looks like panfrost_prime:gem-prime-import is failing atm: https://lava.collabora.co.uk/scheduler/job/2214987 Cheers, Tomeu > Thanks, > >> Regards, >> >> Tomeu >> >>> I believe at least patches 1, 2, and 3 can be merged. 4 and 5 are mostly >>> useful in conjunction with 6 and 7 (which are not ready yet), so I'll let >>> maintainers decide. >>> >>> Thanks! >>> >>> Nicolas Boichat (7): >>> dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 >>> arm64: dts: mt8183: Add node for the Mali GPU >>> drm/panfrost: Improve error reporting in panfrost_gpu_power_on >>> drm/panfrost: Add support for multiple regulators >>> drm/panfrost: Add support for multiple power domains >>> RFC: drm/panfrost: Add mt8183-mali compatible string >>> RFC: drm/panfrost: devfreq: Add support for 2 regulators >>> >>> .../bindings/gpu/arm,mali-bifrost.yaml | 25 ++++ >>> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 7 + >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 +++++++++++++++ >>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 17 +++ >>> drivers/gpu/drm/panfrost/panfrost_device.c | 123 +++++++++++++++--- >>> drivers/gpu/drm/panfrost/panfrost_device.h | 27 +++- >>> drivers/gpu/drm/panfrost/panfrost_drv.c | 41 ++++-- >>> drivers/gpu/drm/panfrost/panfrost_gpu.c | 11 +- >>> 8 files changed, 326 insertions(+), 30 deletions(-) >>>