Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp449995ybv; Fri, 7 Feb 2020 02:25:41 -0800 (PST) X-Google-Smtp-Source: APXvYqyAcVQ7u4FnvtP2ZVl59hJg+EAJ2QUR2SzP89kTcZ3tYLG08erYqq9l8iA07pnTR5qjhWWD X-Received: by 2002:a9d:a68:: with SMTP id 95mr2047025otg.87.1581071141349; Fri, 07 Feb 2020 02:25:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581071141; cv=none; d=google.com; s=arc-20160816; b=sR+eNBLu4s98aDPzCQBsJ2pkCrL2hEhlOC3yLhRjbuJRNNzed0s01IfMXMr93g/B7Q EjHkbFkGeUZE1w28vDTTkxwlULZfjnIWQa36mFIAUUDcuoYfSubS66Uk5qsr6IpIS/A0 i7AEK3TS3zXAE3bFfS2BHseMeOevm6X8FOYJBiZuVruQNx5NtxRe9D+BhR5aIl8v4JNv o7IA2jbMxvuCLM/4drSW23nU1dEsOsDKg0jF0sM42l+u608a6D4jPAqn8wmBeqG1/79q 98MLGjBTWmRKSXK/v+qG/NfjYFXHyFsQADLDzpBSJKKQVw4ZyIF1dASxbS/2IJrtff4G 2+Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=IeuwhOsheiCC/8tMcq6mdnJTZFMshdH2e9IQRNw2Jxo=; b=uc2zEZzZpA/v3Y5yVcjG033DMqkDvIsZBkK8HdOOEYEDUT8HO8E2UN4SswYTdvMisZ UWGgKDjSiTjgpujsDSzx94TuTey2bz221JYP82c2deLR1ctKB6bZjkodtAZikgE7EqIS JP9hVA3h6HLnzf7seHfQE5XBdGLv0GFNYkhppV/d2kgExhumusJn6DhjfrknFtNdzVlU v7j+N1o0DSMa4MmvlaIuR/l61iKuzGDblZivkrFpmzgLudh5Z2RdoYoGO/MDNeStIeCk loN7TQ7mVsPWAyYzJYIjkIJO44EAgZGPvokOGjZQkpAnU8aNl69Swe7EhuHv/DBm44FY mo2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si1469480oti.22.2020.02.07.02.25.29; Fri, 07 Feb 2020 02:25:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbgBGKYg (ORCPT + 99 others); Fri, 7 Feb 2020 05:24:36 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40684 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGKYg (ORCPT ); Fri, 7 Feb 2020 05:24:36 -0500 Received: from localhost (unknown [IPv6:2001:982:756:1:57a7:3bfd:5e85:defb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C454715A3284C; Fri, 7 Feb 2020 02:24:33 -0800 (PST) Date: Fri, 07 Feb 2020 11:24:32 +0100 (CET) Message-Id: <20200207.112432.420753747470150864.davem@davemloft.net> To: zhengdejin5@gmail.com Cc: vkoul@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, niklas.cassel@linaro.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net: stmmac: fix a possible endless loop From: David Miller In-Reply-To: <20200206152917.25564-1-zhengdejin5@gmail.com> References: <20200206152917.25564-1-zhengdejin5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 07 Feb 2020 02:24:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng Date: Thu, 6 Feb 2020 23:29:17 +0800 > It forgot to reduce the value of the variable retry in a while loop > in the ethqos_configure() function. It may cause an endless loop and > without timeout. > > Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") > Signed-off-by: Dejin Zheng > Acked-by: Vinod Koul Applied and queued up for -stable, thank you.