Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 00/15] AMD ntb driver fixes and improvements
To:     Arindam Nath <arindam.nath@amd.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Jon Mason <jdmason@kudzu.us>,
        Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <allenbh@gmail.com>,
        Jiasen Lin <linjiasen@hygon.cn>,
        Sanjay R Mehta <sanju.mehta@amd.com>
Cc:     linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
References: <cover.1580914232.git.arindam.nath@amd.com>
From:   Sanjay R Mehta <sanmehta@amd.com>
Message-ID: <a8e98fe8-25da-3ea7-a204-2fee07c6061a@amd.com>
Date:   Fri, 7 Feb 2020 16:28:53 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <cover.1580914232.git.arindam.nath@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: d9cf9741-f873-49d1-4987-08d7abbcc07c
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2020 10:59:07.0834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6r79La5wWPGuxwwwJNhkwWgQ9rKYdm0dNPl5s8yImPeMC8KQXolBoBe9xxV4goLudHTyblvvoZIcUGj6rQLsag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2944
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/5/2020 9:24 PM, Arindam Nath wrote:
> [CAUTION: External Email]
> 
> This patch series fixes some bugs in the existing
> AMD NTB driver, cleans-up code, and modifies the
> code to handle NTB link-up/down events. The series
> is based on Linus' tree,
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
> Arindam Nath (15):
>   NTB: Fix access to link status and control register
>   NTB: clear interrupt status register
>   NTB: Enable link up and down event notification
>   NTB: define a new function to get link status
>   NTB: return the side info status from amd_poll_link
>   NTB: set peer_sta within event handler itself
>   NTB: remove handling of peer_sta from amd_link_is_up
>   NTB: handle link down event correctly
>   NTB: handle link up, D0 and D3 events correctly
>   NTB: move ntb_ctrl handling to init and deinit
>   NTB: add helper functions to set and clear sideinfo
>   NTB: return link up status correctly for PRI and SEC
>   NTB: remove redundant setting of DB valid mask
>   NTB: send DB event when driver is loaded or un-loaded
>   NTB: add pci shutdown handler for AMD NTB

The patch series looks good to me. Thanks for the changes.

For all the ntb_hw_amd changes:

Reviewed-by: Sanjay R Mehta <sanju.mehta@amd.com>


> 
>  drivers/ntb/hw/amd/ntb_hw_amd.c | 290 ++++++++++++++++++++++++++------
>  drivers/ntb/hw/amd/ntb_hw_amd.h |   8 +-
>  2 files changed, 247 insertions(+), 51 deletions(-)
> 
> --
> 2.17.1
>