Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp626464ybv; Fri, 7 Feb 2020 05:42:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxgWD8SnGdt/FwIATGxLjyJ33jsbsoqaVm/3AHSl/cUQriBza0HOqknqzOTpyn1glofwaRu X-Received: by 2002:a9d:7f81:: with SMTP id t1mr2572460otp.95.1581082945265; Fri, 07 Feb 2020 05:42:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581082945; cv=none; d=google.com; s=arc-20160816; b=gjKacnp5+ZSSThVKFtgF9MOTKyi7jOEvZRgDbH+fw77l4f9DPOfzTCfzlVygGuzlbW Fe00Jt3AA7bsVo1CWjRC8Z4jLzEKuk0joWUb+YvUJWTXwqrGfsGDf2iHMtfOu2DBRCzF BUB91TxStug08GfOSIklsDvnXdPDf2f4SXhzEqicxIDGJ2XLRcHQoejuGGNHvraKh/X2 uWum5AGejXgAz3jomM/Uekqd5BF1WJepuwH1yI3fIvhR1fSopEn88lHIRGdOk8IGzpRc M0xlZ4Av20LAfZBTxcsLEPCZo2+a37MVw2RtMSENp2v98wB1NXYcr0rWeUycPF2+sOAp m2Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=+chzd5YTlJXfwCHdGMRTXrrA2aj2F7AXsMOKrEm2tr4=; b=oWFAVpodIDMgj9j0tcoUE+U2RzJUy9V1ULB6gieEOWh2T3LHUKDntdAOLqALe5eim6 FiUvYFiHkTUoWaZVrumwADcprsb1rV4ee+sVS8QWWHrlgb14Tj37ZPg41qYaKz1h+KNc B6H1mCVZElW7YLpiaGsBKdp5/ic0fc5rcOrJJ+XntSihtMtNTj8BRZavt3miMHp4FYDA fVhas2CgYGBUhPpwzmUxWJzCMkBrlQyfcwLzcEW7e5G+JRM+WPWdVXcs8adxtxedIyo2 yS36QAoAOdAQBiUlJwuNGX6IfJdSo5Eq5Il2EpLf8LY24e/Iwx0Cag3oQiBd/u0Lj1z1 GoSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="WQ1fULw/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q66si3922974oig.65.2020.02.07.05.42.13; Fri, 07 Feb 2020 05:42:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="WQ1fULw/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727130AbgBGNjg (ORCPT + 99 others); Fri, 7 Feb 2020 08:39:36 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45842 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGNjf (ORCPT ); Fri, 7 Feb 2020 08:39:35 -0500 Received: by mail-wr1-f68.google.com with SMTP id a6so2691686wrx.12 for ; Fri, 07 Feb 2020 05:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+chzd5YTlJXfwCHdGMRTXrrA2aj2F7AXsMOKrEm2tr4=; b=WQ1fULw/Hx71WFRzz2+kWW1dDM0fq0xejDzbYEP8puWWAyu5iJEb6zKvLJd0eJfKNg k13Hpuzsu7DvK3EgQpEgZWuO5D1L2DMGkgLmu9nuwJieVBvZY/1iV7CauShj3tWKiX7o +qbY6esm+ppNAQH6ycVeFHWZGtuAyVyQhsWIWvrGcwFq1TAtpSVrJnZprb8R5165+3HB 2TPdw94cYJIOixT+rnKekG1ZNLvmpQk8HgVDeEmTT69qqXY4z7taxbeN5iX20g3BDJ+u IC2pJfq0dksQEXOG2BKY7DJYK0/m9EvmaTfEN9PyMJ6XLOmSWcPReShnxTdooFwlsuSP wG5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+chzd5YTlJXfwCHdGMRTXrrA2aj2F7AXsMOKrEm2tr4=; b=rQt4kNzb/pLdBljsnJ5Ov5lK6WMXwevorV64bk5yxyUsG90uNLpz2qD+Yr68ctZTbV PBwFk9/bufm5E45X30mRD2e76UFnNhjtQd/YT3c9xIhnS0OuT+4kjvB9+mNBSWmD7YuY bX9eBThrE6+VZVLTtvl0e0JMRvNmJ92jZPaxqoLOAaK/pyVllGZ3VzL9dYPh0eylqaM0 E5+Iz+atDiUlOJSeIlMnwwoJHPFd6EjbBR6Ma9ilBdVL/tUJDTVGuf31yyegVaqndYt7 xRExrziL0vpOsN6C0ohDbJg4VKcbwL8Qf2z8728gNZnRfuKKbLOzXMZIG9KXKBvx07ym xCIQ== X-Gm-Message-State: APjAAAUXoObHckUoEYmb8aUEkWOVRKb8JR7jfOD73Xh2GXB/wojZGojm 3wVfAc5s1cKToaj249QjbA6Mrx7GCQL7uA== X-Received: by 2002:adf:e68d:: with SMTP id r13mr4733107wrm.349.1581082772760; Fri, 07 Feb 2020 05:39:32 -0800 (PST) Received: from [10.1.2.12] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id m21sm3413649wmi.27.2020.02.07.05.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2020 05:39:32 -0800 (PST) Subject: Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const To: a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, boris.brezillon@collabora.com Cc: linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200206191834.6125-1-narmstrong@baylibre.com> <20200206191834.6125-7-narmstrong@baylibre.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwU0EVid/pAEQAND7AFhr 5faf/EhDP9FSgYd/zgmb7JOpFPje3uw7jz9wFb28Cf0Y3CcncdElYoBNbRlesKvjQRL8mozV 9RN+IUMHdUx1akR/A4BPXNdL7StfzKWOCxZHVS+rIQ/fE3Qz/jRmT6t2ZkpplLxVBpdu95qJ YwSZjuwFXdC+A7MHtQXYi3UfCgKiflj4+/ITcKC6EF32KrmIRqamQwiRsDcUUKlAUjkCLcHL CQvNsDdm2cxdHxC32AVm3Je8VCsH7/qEPMQ+cEZk47HOR3+Ihfn1LEG5LfwsyWE8/JxsU2a1 q44LQM2lcK/0AKAL20XDd7ERH/FCBKkNVzi+svYJpyvCZCnWT0TRb72mT+XxLWNwfHTeGALE +1As4jIS72IglvbtONxc2OIid3tR5rX3k2V0iud0P7Hnz/JTdfvSpVj55ZurOl2XAXUpGbq5 XRk5CESFuLQV8oqCxgWAEgFyEapI4GwJsvfl/2Er8kLoucYO1Id4mz6N33+omPhaoXfHyLSy dxD+CzNJqN2GdavGtobdvv/2V0wukqj86iKF8toLG2/Fia3DxMaGUxqI7GMOuiGZjXPt/et/ qeOySghdQ7Sdpu6fWc8CJXV2mOV6DrSzc6ZVB4SmvdoruBHWWOR6YnMz01ShFE49pPucyU1h Av4jC62El3pdCrDOnWNFMYbbon3vABEBAAHCwn4EGAECAAkFAlYnf6QCGwICKQkQFpq3saTP +K7BXSAEGQECAAYFAlYnf6QACgkQd9zb2sjISdGToxAAkOjSfGxp0ulgHboUAtmxaU3viucV e2Hl1BVDtKSKmbIVZmEUvx9D06IijFaEzqtKD34LXD6fjl4HIyDZvwfeaZCbJbO10j3k7FJE QrBtpdVqkJxme/nYlGOVzcOiKIepNkwvnHVnuVDVPcXyj2wqtsU7VZDDX41z3X4xTQwY3SO1 9nRO+f+i4RmtJcITgregMa2PcB0LvrjJlWroI+KAKCzoTHzSTpCXMJ1U/dEqyc87bFBdc+DI k8mWkPxsccdbs4t+hH0NoE3Kal9xtAl56RCtO/KgBLAQ5M8oToJVatxAjO1SnRYVN1EaAwrR xkHdd97qw6nbg9BMcAoa2NMc0/9MeiaQfbgW6b0reIz/haHhXZ6oYSCl15Knkr4t1o3I2Bqr Mw623gdiTzotgtId8VfLB2Vsatj35OqIn5lVbi2ua6I0gkI6S7xJhqeyrfhDNgzTHdQVHB9/ 7jnM0ERXNy1Ket6aDWZWCvM59dTyu37g3VvYzGis8XzrX1oLBU/tTXqo1IFqqIAmvh7lI0Se gCrXz7UanxCwUbQBFjzGn6pooEHJYRLuVGLdBuoApl/I4dLqCZij2AGa4CFzrn9W0cwm3HCO lR43gFyz0dSkMwNUd195FrvfAz7Bjmmi19DnORKnQmlvGe/9xEEfr5zjey1N9+mt3//geDP6 clwKBkq0JggA+RTEAELzkgPYKJ3NutoStUAKZGiLOFMpHY6KpItbbHjF2ZKIU1whaRYkHpB2 uLQXOzZ0d7x60PUdhqG3VmFnzXSztA4vsnDKk7x2xw0pMSTKhMafpxaPQJf494/jGnwBHyi3 h3QGG1RjfhQ/OMTX/HKtAUB2ct3Q8/jBfF0hS5GzT6dYtj0Ci7+8LUsB2VoayhNXMnaBfh+Q pAhaFfRZWTjUFIV4MpDdFDame7PB50s73gF/pfQbjw5Wxtes/0FnqydfId95s+eej+17ldGp lMv1ok7K0H/WJSdr7UwDAHEYU++p4RRTJP6DHWXcByVlpNQ4SSAiivmWiwOt490+Ac7ATQRN WQbPAQgAvIoM384ZRFocFXPCOBir5m2J+96R2tI2XxMgMfyDXGJwFilBNs+fpttJlt2995A8 0JwPj8SFdm6FBcxygmxBBCc7i/BVQuY8aC0Z/w9Vzt3Eo561r6pSHr5JGHe8hwBQUcNPd/9l 2ynP57YTSE9XaGJK8gIuTXWo7pzIkTXfN40Wh5jeCCspj4jNsWiYhljjIbrEj300g8RUT2U0 FcEoiV7AjJWWQ5pi8lZJX6nmB0lc69Jw03V6mblgeZ/1oTZmOepkagwy2zLDXxihf0GowUif GphBDeP8elWBNK+ajl5rmpAMNRoKxpN/xR4NzBg62AjyIvigdywa1RehSTfccQARAQABwsBf BBgBAgAJBQJNWQbPAhsMAAoJEBaat7Gkz/iuteIH+wZuRDqK0ysAh+czshtG6JJlLW6eXJJR Vi7dIPpgFic2LcbkSlvB8E25Pcfz/+tW+04Urg4PxxFiTFdFCZO+prfd4Mge7/OvUcwoSub7 ZIPo8726ZF5/xXzajahoIu9/hZ4iywWPAHRvprXaim5E/vKjcTeBMJIqZtS4u/UK3EpAX59R XVxVpM8zJPbk535ELUr6I5HQXnihQm8l6rt9TNuf8p2WEDxc8bPAZHLjNyw9a/CdeB97m2Tr zR8QplXA5kogS4kLe/7/JmlDMO8Zgm9vKLHSUeesLOrjdZ59EcjldNNBszRZQgEhwaarfz46 BSwxi7g3Mu7u5kUByanqHyA= Organization: Baylibre Message-ID: <61ddf618-dcbc-05b2-99a3-397feda9762a@baylibre.com> Date: Fri, 7 Feb 2020 14:39:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200206191834.6125-7-narmstrong@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2020 20:18, Neil Armstrong wrote: > Before switching to bridge funcs, make sure drm_display_mode is passed > as const to the venc functions. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_venc.c | 2 +- > drivers/gpu/drm/meson/meson_venc.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c > index 4efd7864d5bf..a9ab78970bfe 100644 > --- a/drivers/gpu/drm/meson/meson_venc.c > +++ b/drivers/gpu/drm/meson/meson_venc.c > @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic) > EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat); > > void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic, > - struct drm_display_mode *mode) > + const struct drm_display_mode *mode) > { > union meson_hdmi_venc_mode *vmode = NULL; > union meson_hdmi_venc_mode vmode_dmt; > diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h > index 576768bdd08d..1abdcbdf51c0 100644 > --- a/drivers/gpu/drm/meson/meson_venc.h > +++ b/drivers/gpu/drm/meson/meson_venc.h > @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc; > void meson_venci_cvbs_mode_set(struct meson_drm *priv, > struct meson_cvbs_enci_mode *mode); > void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic, > - struct drm_display_mode *mode); > + const struct drm_display_mode *mode); > unsigned int meson_venci_get_field(struct meson_drm *priv); > > void meson_venc_enable_vsync(struct meson_drm *priv); > Forgot to add: Reviewed-by: Boris Brezillon from 20190821203233.47137f57@collabora.com Neil