Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp704652ybv; Fri, 7 Feb 2020 07:04:39 -0800 (PST) X-Google-Smtp-Source: APXvYqzzaExZX4xYpC3WGdxjz8jxXjdOnv/HeuEIct8wUNGdo3ksGfxtXW/wy85X0WPvV1bA/yLD X-Received: by 2002:a9d:4c81:: with SMTP id m1mr2997978otf.5.1581087879634; Fri, 07 Feb 2020 07:04:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581087879; cv=none; d=google.com; s=arc-20160816; b=IhSYhxZPz2zUvCf/IcmHqf1QxAKzGthY49nDdh2ODE6Bwxl0WEUhqxIr/p/Xgnl3ke sodURqd2sp/aFZ8dL9Iz5UZ4LsYbC3xvybmItuxeaWzXsGZR9+opoHeIIBXWKszkbldM MT6WWksWJ/AEdarXePWP8bpRBZHZw65H16A4xs8PA6K5xRxnSJjVsQBDEX17oPj07yqw 3xkWDAfPw7JJIGN3uHcUpwxlA5vlvUNQ+EwMxj5+fTIJxFtx0NsW43WGhVLQDOue6aSP 6Z1grM7OybuwAeYLkm1l9ij6xxZoRfWN4HfXEFFaZxi0PnWprUjDoKT46T9viiCnvSer hgbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=rNsv9hHduNqPkVVLHBkfnkwXNn1LkgmA/12DlguYpXc=; b=oTqgiJljFvti11o+VtVF4ZoYmxz11qnhRJKVRap9cinIgkwyVVdQ0Ga3UA2QLWWr+C XKNNm2sSF1A/fneELEBsuyC60cTX6xBovN7ef4BpIBQxcgDECe4oe59Aww2WPofy5RyN qvuBrmJ3yzuIPUDUoRYcRLRp8L4Hd9CVkjbX79SO72m1lXTtLSLscgnVsXO4Zsucn/2G gdPti27neQZPSyBqdxm0QhpWirBqmOqURt4bK6LlJsbLfjhCT8ujT8NHbDLpV5V0xFzJ 8HW1UYnQr6CMQ8EbbVkc79kAITTsqDl8cVd2JwmsUKnD0iDLvcC9Nj3NQX86aEq9ee1x OJig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4si3534173oip.107.2020.02.07.07.04.26; Fri, 07 Feb 2020 07:04:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgBGPCq (ORCPT + 99 others); Fri, 7 Feb 2020 10:02:46 -0500 Received: from gecko.sbs.de ([194.138.37.40]:51940 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGPCp (ORCPT ); Fri, 7 Feb 2020 10:02:45 -0500 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 017F2DFG005561 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Feb 2020 16:02:13 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 017F2B6K000816; Fri, 7 Feb 2020 16:02:11 +0100 Subject: Re: [PATCH] x86: pat: Do not compile stubbed functions when X86_PAT is off To: Thomas Gleixner , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Cc: x86 , Linux Kernel Mailing List References: <198c94a8-12ea-88e7-6f08-b3456473e5c3@siemens.com> <87r1z6xxh5.fsf@nanos.tec.linutronix.de> From: Jan Kiszka Message-ID: Date: Fri, 7 Feb 2020 16:02:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87r1z6xxh5.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.02.20 15:50, Thomas Gleixner wrote: > Jan Kiszka writes: > >> From: Jan Kiszka >> >> Those are already provided by linux/io.h as stubs. >> >> The conflict remains invisible until someone would pull {linux,asm}/io.h >> into memtype.c. > > Err. memtype.c includes asm/io.h already. So it's just the PAT=n case > which is broken. Ah, right, my comment must read "until someone would pull linux/io.h" because only that header carries the stubs. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux