Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp824078ybv; Fri, 7 Feb 2020 09:09:29 -0800 (PST) X-Google-Smtp-Source: APXvYqyL6UQaEUB7F/PanrL2a43Xq49CHx1ehIQ7D4LjK0dgpTa/ngxUTXTHXoR0XW7XN21dCMMY X-Received: by 2002:a9d:7ad9:: with SMTP id m25mr266603otn.13.1581095369205; Fri, 07 Feb 2020 09:09:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581095369; cv=none; d=google.com; s=arc-20160816; b=KbZUgSY/v5hWWyxswA5dQCiOg0p8HtVluDCwdxj5sOLd+8nAkMAYWDiSntHjpU4+ll d5cmRA5+TIUCj3HMBRIsrlr8bPcu0B+9V2A1UlL9X++GXpAtEqF6QtQbXvrj9x4DjHoG yqlFS39ZlKaNqc7Wixyu2aTefWe4oWwpFCbB+iq4gGW55Tdh50yJyPh/UCQs0OGG9da0 TsLxNF8t9rv2bQt2XpcO+VOqSj8O4VrmE1MEM5w88bDUZSERuX5mozAc/fMP7KMPt8Ie eohfhudMnkEpT89U5mWBaryrvDMU1nehaiaDQcw8Vfqsfsv2omwMwG9NHbbSSFHu786x Ze8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=fwksfmnyjSQ3x9KbQRgdJngnABrv8eexrnhnRItn6EY=; b=Af7zxNH/7NPtkyN41j5xPcLHxd7nlj2KJuEo7OAcyk9h57SrmCSbkz+alX1rZEspSG JHHE1cZQggWIvhIdwx3V9YStO/NvYE2DZFd46SCVkMDvUfKv53J9qcnk4d079080HcRz HS9FN7uO1EpwEc35R7t7HHxA4EtLvMBDedSU1WawGO2uGtc9wday33TsGkMYuFgK4RMS x6vsSQPRCGDoeLCPkf50O25FqJXT2GHSidE3spmI0/yt6N/v2c+9pDzuMpiYhogAoe9m +es7ebKAAUbXCFqKIKBmW6rS/vtAiuTGEk3Bp5qqTIyBqjFyrXdws3W/wYLNYUpycF9R fxmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si2036762otr.39.2020.02.07.09.09.16; Fri, 07 Feb 2020 09:09:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727455AbgBGRGt (ORCPT + 99 others); Fri, 7 Feb 2020 12:06:49 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:51093 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727049AbgBGRGs (ORCPT ); Fri, 7 Feb 2020 12:06:48 -0500 Received: from mail-lj1-f173.google.com ([209.85.208.173]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1M7ayR-1is7HH3r9p-007ym1; Fri, 07 Feb 2020 18:06:47 +0100 Received: by mail-lj1-f173.google.com with SMTP id y6so93648lji.0; Fri, 07 Feb 2020 09:06:46 -0800 (PST) X-Gm-Message-State: APjAAAUJHNPXCh/xK8YFHLoStO0M8ozKP/4l15jS3+ofrisLfvHUxlQn iAOqtj8EusCpznG9RAxb7yFTLwI9MAu2e89RTqM= X-Received: by 2002:a2e:5056:: with SMTP id v22mr138394ljd.164.1581095206323; Fri, 07 Feb 2020 09:06:46 -0800 (PST) MIME-Version: 1.0 References: <20191217221708.3730997-21-arnd@arndb.de> <20200207072210.10134-1-youling257@gmail.com> In-Reply-To: <20200207072210.10134-1-youling257@gmail.com> From: Arnd Bergmann Date: Fri, 7 Feb 2020 17:06:34 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 20/27] compat_ioctl: simplify the implementation To: youling257 Cc: Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi , "linux-kernel@vger.kernel.org" , linux-block , Linux FS-devel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:fdtLroLKRF3z9lpaDoAat+saKdez6k1gz9YQ/JdPIcbHjwBh2SR cRQdIW8DVR79qmzqUQuhgKbx+WdYHxoQ0do7i5hr1fVa6EJKg5pC6cROq9wYyK9qhzoLcgM Jqafa17Fe8mwhjeEUUMPq4eC9N+kw6Vs78frR2Xohi8lDaDziOETYvOrzT20OYYC+p1K9mw B2R69JBXeNbHjhZ6gD94Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ly7G1KQZ0uo=:fERR7UDTKiJeYRbOJJZXwJ mKHoYCmN3zdJ+sAOvBYptoQLTQ+oWDBVkJZyHI9LzcBuaRpEuLfs3Zp2V6ao2plD+q1TG1XDq Xb/Kb4xSHeH76ydf6aoLsX3cJjFtUP33xdYVxO8Y/nb/SLZTfIHL4ZsxWMAjDRyXG11s/MrLY H+hMQfE1zvrQtS0daFK0FtVXaYcIBKyzg/mNcyx+JAwfPL56NmG87tgd2rucwMn25h4aqmcdk vkSnMOdjxLE09hNEYb4ldkruUHySCkTOYrDcCaQv51KxO/JT7e76RthjVdrSRsAToK/im3lGZ SgBshuowGaZhBjVoTvxOjjRpdjEZREyKOjdsyz/mAN2vatU84hm47XjiSzZGHncelAXSm8yna QmqaoZoiEM/xS1T8VPiYORLbDkFyhPGdJefplJQsYYzgGElNeXWAjYq1mtl6BJBYvfVNu6Y+y AfOaDuohFym2X6kdekvWRF+Mb8tc3DIZawhs3XSwDHuxB9zWWybsdT6EylCPC8qq1t1Jsvx2D sdm25mQ3KV2Eh94d2mYN292LRd4Xl+AaPRrXLXy7iqeFoaSdfeD2dbOqbSUQx7NPff+R4L0MU YxzKOo26cCY0wfSnBr0HNQoIBJLHx6490ZUJ+lljfNHDbgGKB5oJgy6Ks5kxdePUHG77+s5vj p7vXXS5Gvg6hBpdaNL2TLLL5FBDeXP9ewEXecRIjTvnrx89zGkBupNACJuaTAq2jvX+UYiyT1 FSsrkkExVn047OxAf7yGbgJHoCVETBYmtJ2vRoIKW3MB3juc98dJMslUAAx0Cyhla5i1JXwY2 mhs3w49LwyDWx0dGExupZgph8hBMmhjdsu+F4JHqp5IzM1j3v4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 7, 2020 at 8:22 AM youling257 wrote: > > This patch cause a problem on 64bit kernel 32bit userspace. > My 32bit Androidx86 userspace run on 64bit mainline kernel, this patch caused some app not detect root permission. Thanks for you work in bisecting the issue to my patch, sorry to have caused you trouble. After Christian Zigotzky also reported a problem in this file, I have been able to find a specific bug and just submitted a patch for it. Please have a look if that fix addresses your problem, as it's possible that there was more than one bug introduced by the original patch. Arnd