Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp970637ybv; Fri, 7 Feb 2020 11:51:00 -0800 (PST) X-Google-Smtp-Source: APXvYqwzI431trcvXuwzDkdCl9794GbEgCOFE/AY6juJyKxPRiFaSHsSwoAYdW8xYKpuV4UPgrkq X-Received: by 2002:a05:6808:64e:: with SMTP id z14mr3028181oih.79.1581105060381; Fri, 07 Feb 2020 11:51:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581105060; cv=none; d=google.com; s=arc-20160816; b=JQFqIzYBfYeee/Sc67roSWAHxv3Rh8c6BgXkdaizxb0Ye5SS0daT5oP8liBWbk23JA WpYx0PeCCIvqQjMrSFv/29sKZ2r6k39ETZ1DrmHlGz0LwvvArpDAnDJGe1sNFUXYIVPO iOvxPRuTtqvQhoygQov833BZZhaTHd0SHOZe9OEHuc7wyFxPj6YVirntw+BSCH7rFQhM TWplE+8YV1ll163vty7ioGuCZ9a7yjFOoDOwz7tbiHGP5iGU5aIeHLyvchdEcEEYyiUb KMkX+tAiyOE5Atp+GYsEDnlsFVVIRV+A30s5lvO9/8C0CNJ42gWAe7y/C4yCLXtp6KSM b0QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Gguklwjg0xsDNFEDfdYqm63SotYH7ehSW0K10U8B/lA=; b=MD7G7gxkaPzND5RDfvcX5YYIE2d+gHXitAZRq/CV9ZsGzBN2Q/Lq3ICBiQGWvq8K4Z QiU4AEycZCj32TtcFVdWpnBz/+XoCWPbJ9LbkMp6I42osQfvd6/c83AGSOFyrBmq0Rli aYFhiUHGSgoz9l1J7WwKyJs/uJ2b9hJfqvGZEaWQ1nrCp/jgS5Gc7g01+OG4hh3DtRz2 6Lfhiu/cpEwT+6u+n8G3/UKFP5bXndlFN7KGZY3Tr2U3Jp9fRTvBX529JisFz3fXOeNq mn5Tq9htcOTqPDoSCqi268BfcZCVB7FnK2/qucjgse6ZIQu3AJOGZ4SM3QEdEPsE0aOJ 3kgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q124si4459089oig.228.2020.02.07.11.50.47; Fri, 07 Feb 2020 11:51:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727123AbgBGTty (ORCPT + 99 others); Fri, 7 Feb 2020 14:49:54 -0500 Received: from mga02.intel.com ([134.134.136.20]:38023 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbgBGTty (ORCPT ); Fri, 7 Feb 2020 14:49:54 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2020 11:49:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,414,1574150400"; d="scan'208";a="255511597" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 07 Feb 2020 11:49:50 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j09dP-0003vS-8y; Fri, 07 Feb 2020 21:49:51 +0200 Date: Fri, 7 Feb 2020 21:49:51 +0200 From: Andy Shevchenko To: Andrew Lunn Cc: Linus Walleij , christopher.s.hall@intel.com, Mika Westerberg , netdev , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , jacob.e.keller@intel.com, Richard Cochran , "David S. Miller" , sean.v.kelley@intel.com Subject: Re: [Intel PMC TGPIO Driver 5/5] drivers/ptp: Add PMC Time-Aware GPIO Driver Message-ID: <20200207194951.GM10400@smile.fi.intel.com> References: <20191211214852.26317-1-christopher.s.hall@intel.com> <20191211214852.26317-6-christopher.s.hall@intel.com> <20200207172844.GC19213@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200207172844.GC19213@lunn.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 07, 2020 at 06:28:44PM +0100, Andrew Lunn wrote: > On Fri, Feb 07, 2020 at 06:10:46PM +0100, Linus Walleij wrote: > > OK this looks like some GPIO registers... > > > > Then there is a bunch of PTP stuff I don't understand I suppose > > related to the precision time protocol. > > Hi Linus > > I understand your confusion. The first time this was posted to netdev, > i asked it to be renamed because it has very little to do with GPIO > > https://lore.kernel.org/netdev/20190719132021.GC24930@lunn.ch/ And besides that I didn't see it in internal review list, so, it needs to be very carefully reviewed. I already saw some not good formatted and questionable code. -- With Best Regards, Andy Shevchenko