Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1023342ybv; Fri, 7 Feb 2020 12:54:21 -0800 (PST) X-Google-Smtp-Source: APXvYqyJfJJxiEobCj5A4Voqwvo+5CpdbY129/US54mMczDyc2vxzVRHLnXSu88VgW5B+44MMqZf X-Received: by 2002:a05:6830:1d55:: with SMTP id p21mr976597oth.145.1581108861381; Fri, 07 Feb 2020 12:54:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581108861; cv=none; d=google.com; s=arc-20160816; b=UpEm4aooRg7iwPOK1ZhMZ0dPLT/7bQmZsi+3NKedIIQh3hZT/xR7Gv8GnETucjwREm 0EBC11g/Vy7E9zRwckFgHB8jzC1+4YUORf/pKZlKS4MdWoHLILrfkxXyJ4+vFgetR/9R zedCnBWlGX3QyAQdogPRCbZmzfJ0MKLIdJmoh42t6QNpXqmBjZJDpICspIWHZDYmyJcC ZGbkC0UYO1up1U9VzbCGns4sRWeaeNh3XmPyhxxX8UJ64A+AI3A7n6sHK/nTOebl2ff/ MlmZBs+kW7RoWBuBijUj6+P/apDrNhD+h3+fxaH9lc1dUBV5+8ppMsyh4iF1Cv/85NHe dFBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=gPAsDsH3JFu6Z/PO2T9two+jAgepbuUh+wb+Brcdscg=; b=gcmiIMr95geTs7qQ9JCc9RDrkTohEVxA4qizqXkGSYN6TNQ1LBc45LN71cGqDTVjLG NEiNXkOF9T+DkQe34eSkJ7wpvEr28H2xm+Z16XPH29Bsr1I5XHZTtbeW/VHv2juXLn8A pXrJwYcdAGBzmmOs8kbzAi/yfs6D+zz8LHCCLTy4wNfhFiKtCiWmajQEeyKQMqiCcGw6 IhiX1wg0ulGgnsKkPiVUB8zmmMQ2qUqEnWIz9llYsJYwmj2rNF2tLLhc6d5LNl6x9LuS WK8MMOwyJ4C2SRSGHnT+Hj9RZXJuZaRy58HpmJDd3V7vWLvt3a4PL2Pk2lhX4dzkw6Yx eyGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=jFDm3UdT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si264745otn.35.2020.02.07.12.54.09; Fri, 07 Feb 2020 12:54:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=jFDm3UdT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727317AbgBGUxF (ORCPT + 99 others); Fri, 7 Feb 2020 15:53:05 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:34384 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726947AbgBGUxF (ORCPT ); Fri, 7 Feb 2020 15:53:05 -0500 Received: by mail-io1-f66.google.com with SMTP id z193so1032791iof.1 for ; Fri, 07 Feb 2020 12:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=gPAsDsH3JFu6Z/PO2T9two+jAgepbuUh+wb+Brcdscg=; b=jFDm3UdTaFobl8KlNZ+xx/OQpMdMEP0sLcKc6IIsBGRY/MIihU7Mgsj3q9XSgoaByQ IU6oR72HeXUVoJaDuENimaiQ7FTTNbejEkhdfZwIZyu9m6Mm1FnNkx21JF40GvLdA8up sMd1yFJAgN7UWzMOKXCKHJt7RseuAcC+5iy2+zH7w/fGdzGSQvfDPrPqxhbSdyKNiqkA c7pscdNnS8SSX8s+Lyulp5Tw0IOKY6P5OcwHaKiYrAKa9rXAqVnAnUgjr9A4rfkvj8iT 9n5yYTngI3LNshykuhlFAnyFnIeNg1OfWy44ZA22zeWnM7dMl6mxqY3H2FpdW3eYfNve vOiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gPAsDsH3JFu6Z/PO2T9two+jAgepbuUh+wb+Brcdscg=; b=MCiU/spjKcXP/gy4eidfWJr15k5phCbItc94H6Z4DtrkoHvbc/kAwSOOzKpfMNMvNv wO4tABfgl08yoC46vfI9xA1Zvm2no+vRrUcDmHpOJLe3M1zRl8EpxnmDbxFZChJjotA9 Z0qgpkbEyNUWky8R9arR6fwhFlKIP4Zs6nwqBHWQy6HI8e5RvlWIrRaF8tulVaNFzskc GTWHFaAJFGi43Di9BrlR2J77FpBL6pXtSXNHy24tXbtZPtL6a6lzqfgj0n0sZIwPbvwH JMCeI/z6fr2P8Gr2lafCHjOSVXzwVASKFwd2ud6XlglxV4zTgqGvru5db9iQoGXy1C4G BO4A== X-Gm-Message-State: APjAAAWf4TFsNwK5Abb6ElXSYZk+41ANkex4ZGLuKXs6v/Q4de8Dk/lK Zac/HU3hHUf8IhTMSpwrUfMcw4a5xkQ= X-Received: by 2002:a02:ca59:: with SMTP id i25mr323779jal.102.1581108784007; Fri, 07 Feb 2020 12:53:04 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id l81sm1669041ild.87.2020.02.07.12.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2020 12:53:03 -0800 (PST) Subject: Re: [PATCH] io_uring: add cleanup for openat() To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <6729b8f1-f048-8cba-8a7a-45ef1d8c3256@kernel.dk> Date: Fri, 7 Feb 2020 13:53:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/20 1:45 PM, Pavel Begunkov wrote: > openat() have allocated ->open.filename, which need to be put. > Add cleanup handlers for it. Should this include statx too? -- Jens Axboe