Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1040213ybv; Fri, 7 Feb 2020 13:14:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzjWSgSwRKb83tGr2E/PN3DN3CbvMhkWEveLiDKnmVjO4MTJeCRem0yZXnE7BhS5blRSVAA X-Received: by 2002:a9d:7304:: with SMTP id e4mr969253otk.99.1581110068525; Fri, 07 Feb 2020 13:14:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581110068; cv=none; d=google.com; s=arc-20160816; b=bMbvxocEARqra8hFSyZhvVUSzeY2FkLI6B5ECOiKKxp46Ze+kO8BTwS9GD4wgZM00a fbblPvNGXNp2+BuF0h1ReMKDBHCmxCS363uATMet03x1agM9KaWRbeOpWrlUP/XC9Ryu NMVdm4lbDzEVHT7Kf/46rxkWdcjQPiuroAJlgfZY1ZjG9n7l8s8hge5WsGsejCJWvc+9 cEqxpj6ErEI6LQS3o38yu0/ChhBrC1WDaZN8nSvEwAtAs20RsJ4MxBoEtg3IbdJTxy3m ES34RSlYae96btFrBeHdsXhXh8+8s6sWMUO6/erE5SSQsQtosxvEy3iMH2Kq14q2qvWM QlpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=6EzOdMFQDDyqSndW99ah55WjF8ZUkRxUPd0ynxNiAwQ=; b=EEftVLD9M2srnd0wCwAgKjNbxWovTN1PswDho4toSgBL7PTaChB/1QcPCUHoSgiI43 1WAhwTxVR5Skg9LgLImF7Msg0YV8EWV0/H4Sq7P4B/HidrbAzIizP73UYWbWggPYK5vd N0n1NsaDHXTsZRxPD4Cu37uEi2eX4duUHfRYaoLVdUo+nXs1Gq+6ajrWou3jiMPZxbf5 EX1/a2kTEwEEU9HMnINT7T2qCK1bgbtMQi67oTxDQeRwvLLa/wz1DtKy6+EsiSmkgQST CHAIjia9x3Xg0ZCS0B93ZbJpmmwrl53aU5Oa98MD/zk3gAlJAhIHLDManoMooDMnXIQe BLXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=LYKwR+mR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p83si4585844oih.198.2020.02.07.13.14.17; Fri, 07 Feb 2020 13:14:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=LYKwR+mR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727379AbgBGVNM (ORCPT + 99 others); Fri, 7 Feb 2020 16:13:12 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:51589 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727113AbgBGVNM (ORCPT ); Fri, 7 Feb 2020 16:13:12 -0500 Received: by mail-pj1-f65.google.com with SMTP id fa20so1443513pjb.1 for ; Fri, 07 Feb 2020 13:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=6EzOdMFQDDyqSndW99ah55WjF8ZUkRxUPd0ynxNiAwQ=; b=LYKwR+mRTMNgXNB/D1PynJqHkuZYdx5csduEGZ/anaetY3PVg9+VudOmIl9A3EeAWG KffLLDcreSmN1Im4K08hw/z6DQxQvXromzoSEVlinOAbvhi2Nh7OLRCp3WTRVol46dni Cko8Dq83VcYZZew6cabUU4OgUVKvx2mJqMAY+O2paRCjgmOhI/vqCadFZdBGj8ZWqvci AbPsJ7YjsGrJz3snXz4iKSQKyaXsayoyDI1aD4DW+U4efAwDGIFyv69Rz/6laovbX8/c 0D66n1Bfrje3dH6sAT4ya3SCxt019BSULleFYDocpjI57I3G1NEfBaW3jEYEis7CG3XC K8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6EzOdMFQDDyqSndW99ah55WjF8ZUkRxUPd0ynxNiAwQ=; b=F682pblU//8osfQwrdYB92lILueUK0vih0P6bGboQ0WyYmfX3GXKp87nAatroNCygU GfPkBnAr2HIuXcyEtZAETsD74ywpg2I6QmwejMWKZ3p8AKh738DsyCBAj6AX9lQQsRXj xvXhuCrzTF52BWqUbbwUaZ25lDc5qk35QJ9WhUt6LZF15HQ23OJQi3V5/Ef6syaZUwYx QU7F8aRducreyGsC0UOzYfRRSFLPi+rWYMK2/zcxrACIHahE3c0UHtTXKmgi2rnfE0E4 4DHbhrivllEcAN83litWpI4gFf31CoXqGvrv7XJZyENDureNSvxXaX+dEigLW2Y2YOFU UMuA== X-Gm-Message-State: APjAAAWpzQBuc5YSFWj6uNzmBqNFTR0sDFYd35egWGSg5d8jXTn1HXOG tV7Mu3h4OSR9zqmT2vf8mxmF8Ost27Q= X-Received: by 2002:a17:902:fe93:: with SMTP id x19mr299090plm.155.1581109989661; Fri, 07 Feb 2020 13:13:09 -0800 (PST) Received: from ?IPv6:2620:10d:c081:1131::134e? ([2620:10d:c090:180::3860]) by smtp.gmail.com with ESMTPSA id r26sm3903941pga.55.2020.02.07.13.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2020 13:13:09 -0800 (PST) Subject: Re: [PATCH v2] io_uring: add cleanup for openat()/statx() To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <10b7caed-06dd-f6a0-24f1-648968011e40@kernel.dk> Date: Fri, 7 Feb 2020 14:13:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/20 1:59 PM, Pavel Begunkov wrote: > openat() and statx() may have allocated ->open.filename, which should be > be put. Add cleanup handlers for them. Thanks, applied - but I dropped this hunk: > @@ -2857,7 +2862,6 @@ static void io_close_finish(struct io_wq_work **workptr) > } > > fput(req->close.put_file); > - > io_put_req_find_next(req, &nxt); > if (nxt) > io_wq_assign_next(workptr, nxt); -- Jens Axboe