Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1785671ybv; Sat, 8 Feb 2020 06:01:24 -0800 (PST) X-Google-Smtp-Source: APXvYqwstVhCz99stJW3lnJQ3UNVcRBMUtHOGFGMR+xI6v+pf1BW7abErwJfT1jPJ6wUdh7cx1Hp X-Received: by 2002:a05:6830:1555:: with SMTP id l21mr3301743otp.41.1581170484266; Sat, 08 Feb 2020 06:01:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581170484; cv=none; d=google.com; s=arc-20160816; b=vB80oR9c9TCrre5Fdmk6nVOxrcpWDx6+gmPi2E0jqXScrUBmxpqiAKG/+dLKdk1lfJ /wE7KiJ6f5Kzn/ZG3GMXYahRIY62+zT+AO8msiMaToEbPMMKYAfmNyv0uV94yaG7wVyk Wu2v42CTa71BUUq+/YKUEtZSjJ2F8Gcefdz8fjoNBrARxEl0+9Ln+ZScH3hUjTiPfqti 2mi36c3/gd4CkDqyfiIm66PBTvaIlaX/4W6RhGBaDgs6Cne9jqp8oYr5Mb6/Ax2iEFYw lUEUC0QsM4Drg44LeHH5sC6/a/02orWReHYxxC+z5zM0ByVbUd7wYwhfMWJUUsfXBgMJ vMoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4GTM9u3u3zBEVdpUj2dJBoJj+yP6/r0tC+MqY+xoC5s=; b=BQ6tQJoFMDBNSmdZcBlyLgJ5klHnDP2fu1XCJ2MZR7zyiXqTNIYXufOLmiCARMluHc PBGZHuMv0aHExqYqB6qZUGOdlrA+aLA3O4jQj+z30T1s0YBzNunqkJd41V+ajdNfNB6i vJorcOcQw7JM7I+RgSWE+3zwbUE5oPw68cQ/SZYMZJjmgSfiPVt5AZP0o3M01P8pBawH h6xXJN6ofmEhwXo6KDIGuQouwOwiN2j0C2+89mnrVpDAKcEwaofF4DGwlf3GJvUf3ScF b6d/doxHE4wL2RnOttKOxYLvNPMb1MPgNkhBOOZqr4LMw9t3XlkupQjLIwOo1uHI5FFr +SWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si5537677oix.109.2020.02.08.06.00.44; Sat, 08 Feb 2020 06:01:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbgBHN4q (ORCPT + 99 others); Sat, 8 Feb 2020 08:56:46 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:59279 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgBHN4q (ORCPT ); Sat, 8 Feb 2020 08:56:46 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0QbC-0001o5-BH; Sat, 08 Feb 2020 14:56:42 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j0QbB-0003gB-2h; Sat, 08 Feb 2020 14:56:41 +0100 Date: Sat, 8 Feb 2020 14:56:41 +0100 From: Marco Felsch To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Thomson , Stefan Lengfeld Subject: Re: [PATCH] watchdog: da9062: Add dependency on I2C Message-ID: <20200208135641.r552bfcy7jhvmd6v@pengutronix.de> References: <20200208130803.23387-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200208130803.23387-1-linux@roeck-us.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:55:36 up 85 days, 5:14, 88 users, load average: 0.30, 0.09, 0.02 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, thanks for fixing that. On 20-02-08 05:08, Guenter Roeck wrote: > Since commit 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic > safe"), the driver calls i2c functions directly. It now therefore depends > on I2C. This is a hard dependency which overrides COMPILE_TEST. > > Reported-by: kbuild test robot > Fixes: 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe") > Cc: Marco Felsch > Cc: Adam Thomson > Cc: Stefan Lengfeld > Signed-off-by: Guenter Roeck Reviewed-by: Marco Felsch > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index c3c8e0786a99..9ea2b43d4b01 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -207,6 +207,7 @@ config DA9063_WATCHDOG > config DA9062_WATCHDOG > tristate "Dialog DA9062/61 Watchdog" > depends on MFD_DA9062 || COMPILE_TEST > + depends on I2C > select WATCHDOG_CORE > help > Support for the watchdog in the DA9062 and DA9061 PMICs. > -- > 2.17.1