Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] io_uring: fix async close()
To:     Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <6ab2ba6d202439323571ab6536025df0dd8b167e.1581159868.git.asml.silence@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <36dfed78-3399-38f6-7c9c-807803dec72a@kernel.dk>
Date:   Sat, 8 Feb 2020 12:03:19 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <6ab2ba6d202439323571ab6536025df0dd8b167e.1581159868.git.asml.silence@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/8/20 4:04 AM, Pavel Begunkov wrote:
> First, io_close() misses filp_close() and io_cqring_add_event(), when
> f_op->flush is defined. That's because in this case it will
> io_queue_async_work() itself not grabbing files, so the corresponding
> chunk in io_close_finish() won't be executed.
> 
> Second, when submitted through io_wq_submit_work(), it will do
> filp_close() and *_add_event() twice: first inline in io_close(),
> and the second one in call to io_close_finish() from io_close().
> The second one will also fire, because it was submitted async through
> generic path, and so have grabbed files.
> 
> And the last nice thing is to remove this weird pilgrimage with checking
> work/old_work and casting it to nxt. Just use a helper instead.

Thanks, applied. Nice cleanup, too!

-- 
Jens Axboe