Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2631107ybv; Sun, 9 Feb 2020 03:52:39 -0800 (PST) X-Google-Smtp-Source: APXvYqzUo8NOTP7BN7gSZtLG8xd7/UaKYiltRUJtY4TyQhB4bSE0WJZlThqjWTHEpfh178JNEizq X-Received: by 2002:aca:50cd:: with SMTP id e196mr7665696oib.178.1581249158899; Sun, 09 Feb 2020 03:52:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581249158; cv=none; d=google.com; s=arc-20160816; b=VhtMqGBgckTUN8ccR3+KCOVo07GgiyLyl72A8t7y864hJ6ZjbL10SVWkIfOfWEvsyS tYkIfBoLwDFBS6NuAwnvPh2NUALB7ZoZNbvbf6lHzCUjsXtHqZmvV/7DY7gk56LjESOw aVr5AKa682pkeBw4WLHEqy5ZQ3ta7Sx8PULIREo9dNV4WoTsBNXQPLwh4pn2ImOyG8mF ie/XBGHeZoORrHWqMaOYFy2uy/92DGnEjMpqVXp2noZAXEOojuxQak3fIH5P6N7Gskgh iKVHt6weHGjk00tZsp/mD2xwV+eecMOvZb1wDYgYZubGkl6s1PoS7/JEqo+vro5sUXy6 4Lsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=7ypd9so2dFrgbHr/PjvCwvLxYURIQERM57HWlYJTykw=; b=JXmoj0Yx6GrwfCWwSA8pY/zNZbOBOLDzEbZ9W3l5ucdR8QhFCNv5CCDUyCWl65+Wcj picDBEB6vsx1a6ELv+mJIwwRsLK6YDFQuhndkzVMy8lQufL2Dq3k7EE3H25rTSgfvGV7 Y4yyRZOBktcROMzfZA4RpD3v7aQsvA7Mi7ArNpTOvRYVEVQZ6k6GI6FbjREbU3UUBVaM LY8rEDQIgRTlsEkBz1DGBNj8rJUxreUJRUFCHPfC2QmR6YW+yJorGSg6Gf8eM6z++EpX RpqtRJWBFGE0GsNaGYih7z4U06oQRfx6l5HUIg8TBKhiCiARsMrphKPi/sSRgE3TVelb PtBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Hx/aW7/U"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si6754239oib.104.2020.02.09.03.52.03; Sun, 09 Feb 2020 03:52:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Hx/aW7/U"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727453AbgBILtD (ORCPT + 99 others); Sun, 9 Feb 2020 06:49:03 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:40200 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726378AbgBILtC (ORCPT ); Sun, 9 Feb 2020 06:49:02 -0500 Received: by mail-pj1-f66.google.com with SMTP id 12so2941816pjb.5 for ; Sun, 09 Feb 2020 03:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7ypd9so2dFrgbHr/PjvCwvLxYURIQERM57HWlYJTykw=; b=Hx/aW7/UaDciRDeQXQgeyexyBq+kbVxTFEEMLzSYbrxx9mqLQFMP+ujzJYSKYJmq6Y 8RCAo00vyf3w19LuSsYlLPJ94qLIq0u5udGsUCnGtG2oCUHHWCd8LJhIHCboXo5u2+SV zVQcL729sj7OqSXVtBe99zslwOYg1mc+fnKIsyCTjqRBgkbvYUY8OH3aNfXdMJHAt9mK mQk6Hw9U5JE3cxiuPWLERaHeq4Bidrl/0QZZJylVlix2NF79lxg7hkcfqWQI9YKUtb4z CNW2AcUSvZH9EhcP90cc7+HGt0B4aM16G6cnxbUPrcYlGIZL8lFhC88b/S1hgZPqOhhX sWfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7ypd9so2dFrgbHr/PjvCwvLxYURIQERM57HWlYJTykw=; b=PAEeaxry0S0EGlZq31LHE/2VM12mg16Agb/5LSq5Itmf04CjiIo2w2irlR3DeEr2je aGej2aA54U+kGVxqt2efM2h/QxPFrvz6nTWzGPSulTwBpjw3XdT6RBA7fKuurdoSCwJd cVXeFl+WbCjvdtzgtfNKw7mENCS4dT6Tu36hBpppRtEEldAyybxDuv77k488KnaA23Xd yE+PmJOUk0t3onTaDA3aQrYGhViaXG1vIJ2IG4Bi9lgaYprGBN2cUEU4CeLLZaYf8xys DyByrtphXEw3qraNIQlawgQvu1D9U1qyvyoybkUzJOMY/8yaV5uQh/AtTEkPzCU5Nc7G WHzA== X-Gm-Message-State: APjAAAUfAwNIYETIL3cMh8/xMR7C3hIP/qX1vmAN47xMMuZpt/BJYHN9 59V/E/gnXbwnk+1+PcMPnyU4acpI83IS8qt/Czo= X-Received: by 2002:a17:902:758e:: with SMTP id j14mr8084476pll.18.1581248941909; Sun, 09 Feb 2020 03:49:01 -0800 (PST) MIME-Version: 1.0 References: <20200208184407.1294-1-tomas.winkler@intel.com> In-Reply-To: <20200208184407.1294-1-tomas.winkler@intel.com> From: Andy Shevchenko Date: Sun, 9 Feb 2020 13:48:50 +0200 Message-ID: Subject: Re: [PATCH 1/2 V2] mfd: constify properties in mfd_cell To: Tomas Winkler Cc: Lee Jones , Andy Shevchenko , Greg Kroah-Hartman , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 8, 2020 at 8:44 PM Tomas Winkler wrote: > > Constify 'struct property_entry *properties' in > mfd_cell It is always passed > around as a pointer const struct. I guess this should be second patch in the split and it's actually dependent to the first one (won't we get a compiler warning when we drop const qualifier during assignment?). > Reviewed-by: Andy Shevchenko > Signed-off-by: Tomas Winkler > --- > > V2: drop platform_device part Btw, when you prepare series, you may use -vX command line parameter, where X is a version number. The scripts will put v2 in each Subject line uniformly. -- With Best Regards, Andy Shevchenko