Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   David Hildenbrand <david@redhat.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 2/3] mm/sparsemem: get physical address to page struct instead of virtual address to pfn
Date:   Sun, 9 Feb 2020 15:14:28 +0100
Message-Id: <A25CC0EC-73A0-426D-93A0-DD9DDC43800F@redhat.com>
References: <20200209135015.GX8965@MiWiFi-R3L-srv>
Cc:     Wei Yang <richard.weiyang@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Wei Yang <richardw.yang@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oscar Salvador <osalvador@suse.de>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Hildenbrand <david@redhat.com>
In-Reply-To: <20200209135015.GX8965@MiWiFi-R3L-srv>
To:     Baoquan He <bhe@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 09.02.2020 um 14:50 schrieb Baoquan He <bhe@redhat.com>:
>=20
> =EF=BB=BFOn 02/07/20 at 11:26am, Wei Yang wrote:
>>> On Thu, Feb 06, 2020 at 06:19:46PM -0800, Dan Williams wrote:
>>> On Thu, Feb 6, 2020 at 3:17 PM Wei Yang <richardw.yang@linux.intel.com> w=
rote:
>>>>=20
>>>> memmap should be the physical address to page struct instead of virtual=

>>>> address to pfn.
>>>>=20
>>>> Since we call this only for SPARSEMEM_VMEMMAP, pfn_to_page() is valid a=
t
>>>> this point.
>>>>=20
>>>> Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug")
>>>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>>> CC: Dan Williams <dan.j.williams@intel.com>
>>>> ---
>>>> mm/sparse.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>=20
>>>> diff --git a/mm/sparse.c b/mm/sparse.c
>>>> index b5da121bdd6e..56816f653588 100644
>>>> --- a/mm/sparse.c
>>>> +++ b/mm/sparse.c
>>>> @@ -888,7 +888,7 @@ int __meminit sparse_add_section(int nid, unsigned l=
ong start_pfn,
>>>>        /* Align memmap to section boundary in the subsection case */
>>>>        if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) &&
>>>>                section_nr_to_pfn(section_nr) !=3D start_pfn)
>>>> -               memmap =3D pfn_to_kaddr(section_nr_to_pfn(section_nr));=

>>>> +               memmap =3D pfn_to_page(section_nr_to_pfn(section_nr));
>>>=20
>>> Yes, this looks obviously correct. This might be tripping up
>>> makedumpfile. Do you see any practical effects of this bug? The kernel
>>> mostly avoids ->section_mem_map in the vmemmap case and in the
>>> !vmemmap case section_nr_to_pfn(section_nr) should always equal
>>> start_pfn.
>>=20
>> I took another look into the code. Looks there is no practical effect aft=
er
>> this. Because in the vmemmap case, we don't need ->section_mem_map to ret=
rieve
>> the real memmap.
>>=20
>> But leave a inconsistent data in section_mem_map is not a good practice.
>=20
> Yeah, it does has no pratical effect. I tried to create sub-section
> alighed namespace, then trigger crash, makedumpfile isn't impacted.
> Because pmem memory is only added, but not onlined. We don't report it
> to kdump, makedumpfile will ignore it.
>=20
> I think it's worth fixing it to encode a correct memmap address. We
> don't know if in the future this will break anything.

We can have system memory and devmem overlap within a section (which is stil=
l buggy and to be fixed in other regard - e.g., pfn_to_online_page() does no=
t work correctly).

E.g., 64 mb of (boot) system memory in a section. Then you can hot-add devme=
m that spans the remaining 64 mb of that section.

So some of that memory will be kdumped - and should be fixed if broken.

Cheers


>=20
> Thanks
> Baoquan