Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Sun, 09 Feb 2020 23:34:29 +0530
From:   Sibi Sankar <sibis@codeaurora.org>
To:     Evan Green <evgreen@google.com>
Cc:     David Dai <daidavid1@codeaurora.org>,
        Georgi Djakov <georgi.djakov@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, sboyd@kernel.org,
        Lina Iyer <ilina@codeaurora.org>,
        Sean Sweeney <seansw@qti.qualcomm.com>,
        Alex Elder <elder@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        linux-pm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into
 their respective NoCs
In-Reply-To: <CAE=gft6--=zhxfR9G=S0g-5c9YdpvaFWz9dcgV7zJQAzcreZjg@mail.gmail.com>
References: <1578630784-962-1-git-send-email-daidavid1@codeaurora.org>
 <1578630784-962-6-git-send-email-daidavid1@codeaurora.org>
 <CAE=gft6--=zhxfR9G=S0g-5c9YdpvaFWz9dcgV7zJQAzcreZjg@mail.gmail.com>
Message-ID: <9f1675f15fdf6b627f0ce12b1a6cea9a@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-02-04 23:51, Evan Green wrote:
> On Thu, Jan 9, 2020 at 8:33 PM David Dai <daidavid1@codeaurora.org> 
> wrote:
>> 
>> In order to better represent the hardware and its different 
>> Network-On-Chip
>> devices, split the sdm845 provider driver into NoC specific providers.
>> Remove duplicate functionality already provided by the icc rpmh and
>> bcm voter drivers to calculate and commit bandwidth requests to 
>> hardware.
>> 
>> Signed-off-by: David Dai <daidavid1@codeaurora.org>
>> ---
>>  drivers/interconnect/qcom/sdm845.c             | 1132 
>> ++++++++++--------------
>>  include/dt-bindings/interconnect/qcom,sdm845.h |  263 +++---
>>  2 files changed, 609 insertions(+), 786 deletions(-)
>> 
>> diff --git a/drivers/interconnect/qcom/sdm845.c 
>> b/drivers/interconnect/qcom/sdm845.c
>> index f078cf0..8145612 100644
>> --- a/drivers/interconnect/qcom/sdm845.c
>> +++ b/drivers/interconnect/qcom/sdm845.c
>> @@ -5,283 +5,285 @@
>>   */
>> 
>>  #include <asm/div64.h>
> 
> You don't need this header anymore, right?
> 
>> -#include <dt-bindings/interconnect/qcom,sdm845.h>
>>  #include <linux/device.h>
>>  #include <linux/interconnect.h>
>>  #include <linux/interconnect-provider.h>
>>  #include <linux/io.h>

^^ can also be dropped

>>  #include <linux/module.h>
>>  #include <linux/of_device.h>
>> -#include <linux/of_platform.h>

^^ can also be dropped

>> -#include <linux/platform_device.h>
>>  #include <linux/sort.h>
> 
> ..or this one.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.