Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 10 Feb 2020 07:39:35 +0800
From:   Wei Yang <richardw.yang@linux.intel.com>
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, dan.j.williams@intel.com,
        richardw.yang@linux.intel.com, david@redhat.com
Subject: Re: [PATCH 4/7] mm/sparse.c: Use __get_free_pages() instead in
 populate_section_memmap()
Message-ID: <20200209233935.GB8705@richard>
Reply-To: Wei Yang <richardw.yang@linux.intel.com>
References: <20200209104826.3385-1-bhe@redhat.com>
 <20200209104826.3385-5-bhe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200209104826.3385-5-bhe@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 09, 2020 at 06:48:23PM +0800, Baoquan He wrote:
>This removes the unnecessary goto, and simplify codes.
>
>Signed-off-by: Baoquan He <bhe@redhat.com>

Reasonable.

Reviewed-by: Wei Yang <richardw.yang@linux.intel.com>

>---
> mm/sparse.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
>diff --git a/mm/sparse.c b/mm/sparse.c
>index cf55d272d0a9..36e6565ec67e 100644
>--- a/mm/sparse.c
>+++ b/mm/sparse.c
>@@ -751,23 +751,19 @@ static void free_map_bootmem(struct page *memmap)
> struct page * __meminit populate_section_memmap(unsigned long pfn,
> 		unsigned long nr_pages, int nid, struct vmem_altmap *altmap)
> {
>-	struct page *page, *ret;
>+	struct page *ret;
> 	unsigned long memmap_size = sizeof(struct page) * PAGES_PER_SECTION;
> 
>-	page = alloc_pages(GFP_KERNEL|__GFP_NOWARN, get_order(memmap_size));
>-	if (page)
>-		goto got_map_page;
>+	ret = (void*)__get_free_pages(GFP_KERNEL|__GFP_NOWARN,
>+				get_order(memmap_size));
>+	if (ret)
>+		return ret;
> 
> 	ret = vmalloc(memmap_size);
> 	if (ret)
>-		goto got_map_ptr;
>+		return ret;
> 
> 	return NULL;
>-got_map_page:
>-	ret = (struct page *)pfn_to_kaddr(page_to_pfn(page));
>-got_map_ptr:
>-
>-	return ret;
> }
> 
> static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages,
>-- 
>2.17.2

-- 
Wei Yang
Help you, Help me