Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3614379ybv;
        Mon, 10 Feb 2020 03:17:33 -0800 (PST)
X-Google-Smtp-Source: APXvYqyZP2+Mcwc444zGm/MVdrn/speF/rnJ67dxAsusb46gPxcuxVXC81xGsFDq4X/0atfJIxyf
X-Received: by 2002:a9d:7d87:: with SMTP id j7mr626766otn.159.1581333452998;
        Mon, 10 Feb 2020 03:17:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1581333452; cv=none;
        d=google.com; s=arc-20160816;
        b=I1B5ZkCSryQ9JZODsI0x2b9XKzv4qqGqwoN72z8dl09RBQbHEfQKu9ArQFYtFGZJ+f
         b6fhQZfe3XhYfe1jxHk8K4ZVze2VfJtRro88B4AkfSzL473Zhe4Q4jE/tnLDdXWD27pH
         6NUooHYZrI/JTtT0G/Ii4zDKO4Z7XtZ9kg52f8unX5tcJZKtTY8DF1QJ2ttH095UX3Cl
         nxXemdMeToPoNKoXfdjEfnsdRREKLdzLnJ/Y01M69KuOlaRtgGSTOaFsNlsBGLQxEA5/
         ZsBOOqc/8g6RN2vzGGTkeTe/w0YXy0B9g+a0m7WKLBgA7kcae4ni3fqutOglqcRt5OV7
         yu+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:to:subject:cc;
        bh=WuJ/yXuI1Dh+KZQlZCVWcQ74+5I0SnMra5tYUj5mEvo=;
        b=q5zv9mKZZzJjw1mAhiRIpDQBe9POl+tE06da3Rq9XpKrzTPg5khkwDHBirnP0nMDWL
         0b+hDpadbpsHZmxJHmBoutFbxygDS5GgjyXwfQnA5siBmy3S6CYZrgbrvuwl/ugzzSKM
         kb6otf58t/Z4HBuv3DLosohNzCACcKbBfjZuPeU0+RXnROhtlb1mq83C/A/9PgqoQEUn
         Y9DzoceP93DsK2NtX3N/r4+XclRPu8vFv2xesffQtwHV2w1vCjwC2MpxL4oRGsxZf1EN
         ELsPlrinV32FpEjoguPai0RtcV0dkt1OzjqSCdPPiynFPzaiHHeu3nQbllFnjGSnEins
         lvuQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=bg+TX0Nv;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id p22si53076ota.43.2020.02.10.03.17.21;
        Mon, 10 Feb 2020 03:17:32 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=bg+TX0Nv;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727429AbgBJLPP (ORCPT <rfc822;luizmacielfranco@gmail.com>
        + 99 others); Mon, 10 Feb 2020 06:15:15 -0500
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:1236 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726961AbgBJLPP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Feb 2020 06:15:15 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e413b030000>; Mon, 10 Feb 2020 03:14:11 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 10 Feb 2020 03:15:14 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 10 Feb 2020 03:15:14 -0800
Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 10 Feb
 2020 11:15:08 +0000
CC:     <spujar@nvidia.com>, <perex@perex.cz>, <tiwai@suse.com>,
        <robh+dt@kernel.org>, <broonie@kernel.org>, <lgirdwood@gmail.com>,
        <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sharadg@nvidia.com>, <mkumard@nvidia.com>,
        <viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
        <dramesh@nvidia.com>, <atalambedu@nvidia.com>
Subject: Re: [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver
To:     Dmitry Osipenko <digetx@gmail.com>
References: <1580380422-3431-1-git-send-email-spujar@nvidia.com>
 <1580380422-3431-7-git-send-email-spujar@nvidia.com>
 <f8ed8c4a-af40-44b2-b720-4d3a9b660fda@gmail.com>
 <75a63cb3-7d79-7216-6791-3cec57464cd9@nvidia.com>
 <847f4512-7118-e087-1004-685e476e11d8@gmail.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <3c19ef99-8051-76f7-a4d6-0d61182fe6e4@nvidia.com>
Date:   Mon, 10 Feb 2020 16:45:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <847f4512-7118-e087-1004-685e476e11d8@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1581333251; bh=WuJ/yXuI1Dh+KZQlZCVWcQ74+5I0SnMra5tYUj5mEvo=;
        h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=bg+TX0NvBS/rnU/L9+9F0whahwkuD+eMLwfwyayTBaN9q1wi0PEeOTdUyF/B82lNn
         vRu66mZnWVm6HOu1uhchVBqVgz54ANkhaIkyXOECSAxcqtlFc57Sh34oPRnhH1o0Ka
         5j7xN1ivogH8DuQFTD1SN6lcLQ+UpHgCvZQG8ED1lISyv7xVS4njeVlVAllUf0h4cN
         8A1NrMkDvadFZQEexIu58GqRAvjYyV2nwUivJA1/CK3ZoDvZMOWlib7xM0hWnEPjc7
         kZ5KF2a8uIHthYW7zYBe49dYFx5I3iMfFojAwmlGfNsLRb8I9sjtThMHVIcMXqhKpj
         8zI6jS0qpGuew==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2/7/2020 11:52 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 07.02.2020 14:26, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>
>> On 2/6/2020 10:45 PM, Dmitry Osipenko wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> 30.01.2020 13:33, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>> +static const struct dev_pm_ops tegra186_dspk_pm_ops =3D {
>>>> +     SET_RUNTIME_PM_OPS(tegra186_dspk_runtime_suspend,
>>>> +                        tegra186_dspk_runtime_resume, NULL)
>>>> +     SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
>>>> +                                  pm_runtime_force_resume)
>>>> +};
>>> Could you please explain why drivers need the "late" system sleep?
>> It was done to ensure core drivers are suspended first and defer the
>> codec driver suspend
> Suspend order is opposite to the drivers registration order. If there is
> no real problem with that, then you should use the default suspend

> level. Please don't try to fix a non-existent problems.

No. This was done specifically to allow sound core to first stop any=20
ongoing audio activity during normal suspend and ensure a safe suspend=20
of AHUB devices by doing a LATE suspend.