Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3631838ybv; Mon, 10 Feb 2020 03:38:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwCPgsIlXRo/cfIrYGJVzBJYkiMQKM8rDhssbSpVjbwZvfbIcbIHySAtUNbdNjdK4F5zZah X-Received: by 2002:aca:d483:: with SMTP id l125mr531599oig.124.1581334729519; Mon, 10 Feb 2020 03:38:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581334729; cv=none; d=google.com; s=arc-20160816; b=y0HrAn2Xk9fMKMZYc2JKcEQWnjF0bYKF280r90PULifeYk5vfsgIw71RdfxJD9dy/Q 2x/GRShdoyfBe4xG63F/gaonMnWi+oS0EZ1VpAHFacWP7Y/p2eAY9kU7xRXWIElS3nHH pH8xSWHNSY4ViPe/+wdTaeKUtZ3q7tZFCU1gshajcyCAK1zaM4D95f5divVBWmf6RqVG N3lm6Leg1yxTFixhIMOBHuFnrmxrJ8m3CEeYdzRlKzLS9ElooBsoFKEQBP8QIi1st46q Jbxau64N84vbwUIQm+Ks19PQ56kH4mOWQBMGQu1DT3uy5Gxfy0J+nRVjnQpsqM74tT0Y 47fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=fpH5V3Jnvj+HddIqGCU1VUNzWmBVK6MoKZ6REuCkUs8=; b=dExV96Nu3VAX+hYZ2+Fig+gYlG0xFSJve54OXnFzvFFqi5iuKZf9qf2sbGN84hXzJk CnYLj50o2z5HJlTxdcfIKojnHHjs18tM7T2HGmebNnCKQYdtxdvO8AZdoquWLymOCgga LGIHPqRqfZdUwA6XqGWdBJXinwWJ3PUMomZEKF8sXNQlS3RMUkytzmfyNEN+PDYM0MNk 6wPbb3TnUf/CH7DVdDXL8pN0nVyclm7xbh/t0DvKZ422gXvl79yYC4YHgEKFaFjTiPpc HaIsA8M8yYa2VsxqJOKPve8ao2HbE1LNSa8Kd538vR/b5NUPVouVbTaf2IZUG90J5NqR PY6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hpKOCwui; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b25si69060otf.151.2020.02.10.03.38.37; Mon, 10 Feb 2020 03:38:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hpKOCwui; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727484AbgBJLiB (ORCPT + 99 others); Mon, 10 Feb 2020 06:38:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:44198 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726961AbgBJLiA (ORCPT ); Mon, 10 Feb 2020 06:38:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581334679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:in-reply-to:in-reply-to:references:references; bh=fpH5V3Jnvj+HddIqGCU1VUNzWmBVK6MoKZ6REuCkUs8=; b=hpKOCwuinU6Kd43ASLtqBEIWOW19j5586O8uwfiSXvddbENfv3tZJe8vJ6zH4/CD9tyMK3 B3RnmA5AhJgUz5moXWwPtV1htFADltxT84chSqugtabULSInq0GLUH56xsc8bjSinbgTjR YeodeAPZYRwCDkpOVlZH1oZ4+C/+qrY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-2TI-8XQiP-2NdEXXde9fuQ-1; Mon, 10 Feb 2020 06:37:58 -0500 X-MC-Unique: 2TI-8XQiP-2NdEXXde9fuQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1261D8017CC; Mon, 10 Feb 2020 11:37:57 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F05010013A7; Mon, 10 Feb 2020 11:37:53 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3F1A59CAF; Mon, 10 Feb 2020 12:37:53 +0100 (CET) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: Gerd Hoffmann , Dave Airlie , David Airlie , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), spice-devel@lists.freedesktop.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback. Date: Mon, 10 Feb 2020 12:37:52 +0100 Message-Id: <20200210113753.5614-3-kraxel@redhat.com> In-Reply-To: <20200210113753.5614-1-kraxel@redhat.com> References: <20200210113753.5614-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move final cleanups to qxl_drm_release() callback. Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index 1d601f57a6ba..4fda3f9b29f4 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.c +++ b/drivers/gpu/drm/qxl/qxl_drv.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include @@ -132,21 +133,30 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) return ret; } +static void qxl_drm_release(struct drm_device *dev) +{ + struct qxl_device *qdev = dev->dev_private; + + /* + * TODO: qxl_device_fini() call should be in qxl_pci_remove(), + * reodering qxl_modeset_fini() + qxl_device_fini() calls is + * non-trivial though. + */ + qxl_modeset_fini(qdev); + qxl_device_fini(qdev); + dev->dev_private = NULL; + kfree(qdev); +} + static void qxl_pci_remove(struct pci_dev *pdev) { struct drm_device *dev = pci_get_drvdata(pdev); - struct qxl_device *qdev = dev->dev_private; drm_dev_unregister(dev); - - qxl_modeset_fini(qdev); - qxl_device_fini(qdev); + drm_atomic_helper_shutdown(dev); if (is_vga(pdev)) vga_put(pdev, VGA_RSRC_LEGACY_IO); - - dev->dev_private = NULL; - kfree(qdev); drm_dev_put(dev); } @@ -279,6 +289,8 @@ static struct drm_driver qxl_driver = { .major = 0, .minor = 1, .patchlevel = 0, + + .release = qxl_drm_release, }; static int __init qxl_init(void) -- 2.18.1