Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200209111620.97423-1-sachinagarwal@sachins-MacBook-2.local> <CAMRc=Md9gsrm3OXcMgxd7DuiuZUovBB=Bcqfs7zCLApmgV6A8Q@mail.gmail.com>
In-Reply-To: <CAMRc=Md9gsrm3OXcMgxd7DuiuZUovBB=Bcqfs7zCLApmgV6A8Q@mail.gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 10 Feb 2020 13:06:59 +0100
Message-ID: <CACRpkdZbkJjyRPjgrA=i71tkWcD2nAxymMsXYVVrb=t_EsDSnA@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: ich: fix a typo
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     sachin agarwal <asachin591@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        andy@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 10, 2020 at 10:54 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> niedz., 9 lut 2020 o 12:16 sachin agarwal <asachin591@gmail.com> napisa=
=C5=82(a):
> >
> > From: sachin agarwal <asachin591@gmail.com>
> >
> > We had written "Mangagment" rather than "Management".
> >
> > Signed-off-by: Sachin Agarwal <asachin591@gmail.com>
> > ---
> >  drivers/gpio/gpio-ich.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> > index 2f086d0aa1f4..9960bb8b0f5b 100644
> > --- a/drivers/gpio/gpio-ich.c
> > +++ b/drivers/gpio/gpio-ich.c
> > @@ -89,7 +89,7 @@ static struct {
> >         struct device *dev;
> >         struct gpio_chip chip;
> >         struct resource *gpio_base;     /* GPIO IO base */
> > -       struct resource *pm_base;       /* Power Mangagment IO base */
> > +       struct resource *pm_base;       /* Power Management IO base */
> >         struct ichx_desc *desc; /* Pointer to chipset-specific descript=
ion */
> >         u32 orig_gpio_ctrl;     /* Orig CTRL value, used to restore on =
exit */
> >         u8 use_gpio;            /* Which GPIO groups are usable */
> > --
> > 2.24.1
> >
>
> I'm seeing that you have been sending a lot of these single typo
> fixes. This is polluting the history and I'm not a fan of that.
>
> Linus: what is your policy on this?

I don't really have one, I think it's usually nice to do as a drive-by
change when fixing something else. I like what is said about
fixing whitespace and codingstyle issues in the document
Documentation/process/2.Process.rst heading
"Getting started with Kernel development":

  Individual developers are often, understandably, at a loss for a place to
  start.  Beginning with a large project can be intimidating; one often wan=
ts
  to test the waters with something smaller first.  This is the point where
  some developers jump into the creation of patches fixing spelling errors =
or
  minor coding style issues.  Unfortunately, such patches create a level of
  noise which is distracting for the development community as a whole, so,
  increasingly, they are looked down upon.  New developers wishing to
  introduce themselves to the community will not get the sort of reception
  they wish for by these means.

(Jonathan Corbet)

I recommend newcomers to read the whole document, or their
contributions might get increasingly ignored.

Yours,
Linus Walleij