Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3690529ybv; Mon, 10 Feb 2020 04:46:51 -0800 (PST) X-Google-Smtp-Source: APXvYqwUYPqaISZHtDUIp+Ed3CcUOpRh8KHveBuJ1cDFUFHhtqza9pgx21V8WDDje1t94AgPVhpn X-Received: by 2002:a54:4117:: with SMTP id l23mr684200oic.140.1581338810905; Mon, 10 Feb 2020 04:46:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581338810; cv=none; d=google.com; s=arc-20160816; b=o2VXxJF2283wHb5pob+IZ6cjUHDXqZWPbEba48YkK4XZUmcatDyZDX2hnqL6T9AQS/ S+diti9KlQuQxTJ0Af6kNF8Xg5V+Dm1i3S2n/2FLuy6aiVwQ7gdq6GxAm+SkT79vj6jN BS6P9QhPE0v23qluT3KvRbAknOqKI59CXZWoLBpQqgjwCghXxnOet+inhNdYs4UE6Mjf jTrP5caxXjCWepUYl95ORvdtzelT8WSfMZctQNl1/8t0+r9v3jNC8FMWxAZpNKrrR5g4 2qepuNKvFT0uM32eKVNILw6OSsXRCd65wtsboeSeGCu8i5KJ48oFN0JTivDNR0y+/QvJ 7Drw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZEZbzXGtMVHU5RMA1ko4knrx9CeH27i1VAIpPrQC/hU=; b=oTC22wcVJXJADnRFpNZSY4tr9tBKDOeeuLMEAcudtAgZtIeRWu/fEwL/CDI7ICaDgK DRxR3IutSlUYvk81gKlJhCr/22XqrfRfVEErR9jC5Y16yEkniTPe48xmE92CyaEsMBZQ nH9sG++qdKApWHybM2nFq4O+42Y2Jqu8HJNvSI9QrwQ/MgOyzU+oDsQixcq2ll+/wBHd xqFiskc0VJc8PgHhQKg9KHQ56SuAeGT/wM45zzKpJEX23zCI5Cum0XN2wM60GHZ7L2yd JqcCytyvgG2zYvrglkZuVrScJtK9umIAZsxSJTJ3jlqRMnBor6SDfzT87TMYaOG1uSK6 fEzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zEfSocdi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si118713ota.19.2020.02.10.04.46.39; Mon, 10 Feb 2020 04:46:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zEfSocdi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730467AbgBJMpX (ORCPT + 99 others); Mon, 10 Feb 2020 07:45:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:42328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729862AbgBJMlB (ORCPT ); Mon, 10 Feb 2020 07:41:01 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2905621739; Mon, 10 Feb 2020 12:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338461; bh=TjPCIGx70c/xuK9ZFkx8nMSD4QHZZjnp9Dt2xOdRpRo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zEfSocdiHeyoCWGxc6lN4CZWqp+3rcr6AQKYSUxj3+XY2TfqfVPo34cLa7rGhbf86 oU87qIVK2EqCc/IUAJpMMd12AJuJSnaQ/qiW1HYELhig7kJfLeFc8j+ptTj9SdTL0c ejH1leDbXhizJ6IHt5SD9cwWLz6wsDcoC3RkCK/I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Jones , Gavin Shan , Paolo Bonzini Subject: [PATCH 5.5 218/367] tools/kvm_stat: Fix kvm_exit filter name Date: Mon, 10 Feb 2020 04:32:11 -0800 Message-Id: <20200210122444.287159578@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gavin Shan commit 5fcf3a55a62afb0760ccb6f391d62f20bce4a42f upstream. The filter name is fixed to "exit_reason" for some kvm_exit events, no matter what architect we have. Actually, the filter name ("exit_reason") is only applicable to x86, meaning it's broken on other architects including aarch64. This fixes the issue by providing various kvm_exit filter names, depending on architect we're on. Afterwards, the variable filter name is picked and applied through ioctl(fd, SET_FILTER). Reported-by: Andrew Jones Signed-off-by: Gavin Shan Cc: stable@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- tools/kvm/kvm_stat/kvm_stat | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/tools/kvm/kvm_stat/kvm_stat +++ b/tools/kvm/kvm_stat/kvm_stat @@ -270,6 +270,7 @@ class ArchX86(Arch): def __init__(self, exit_reasons): self.sc_perf_evt_open = 298 self.ioctl_numbers = IOCTL_NUMBERS + self.exit_reason_field = 'exit_reason' self.exit_reasons = exit_reasons def debugfs_is_child(self, field): @@ -289,6 +290,7 @@ class ArchPPC(Arch): # numbers depend on the wordsize. char_ptr_size = ctypes.sizeof(ctypes.c_char_p) self.ioctl_numbers['SET_FILTER'] = 0x80002406 | char_ptr_size << 16 + self.exit_reason_field = 'exit_nr' self.exit_reasons = {} def debugfs_is_child(self, field): @@ -300,6 +302,7 @@ class ArchA64(Arch): def __init__(self): self.sc_perf_evt_open = 241 self.ioctl_numbers = IOCTL_NUMBERS + self.exit_reason_field = 'esr_ec' self.exit_reasons = AARCH64_EXIT_REASONS def debugfs_is_child(self, field): @@ -311,6 +314,7 @@ class ArchS390(Arch): def __init__(self): self.sc_perf_evt_open = 331 self.ioctl_numbers = IOCTL_NUMBERS + self.exit_reason_field = None self.exit_reasons = None def debugfs_is_child(self, field): @@ -541,8 +545,8 @@ class TracepointProvider(Provider): """ filters = {} filters['kvm_userspace_exit'] = ('reason', USERSPACE_EXIT_REASONS) - if ARCH.exit_reasons: - filters['kvm_exit'] = ('exit_reason', ARCH.exit_reasons) + if ARCH.exit_reason_field and ARCH.exit_reasons: + filters['kvm_exit'] = (ARCH.exit_reason_field, ARCH.exit_reasons) return filters def _get_available_fields(self):