Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3692360ybv; Mon, 10 Feb 2020 04:48:52 -0800 (PST) X-Google-Smtp-Source: APXvYqzrhpT0qT1/Kee6kYP4m2pXO/5d/is5gZ/ngG+d0OWasvf802KackQZ3K8vMkcaap4GK11b X-Received: by 2002:a05:6830:1248:: with SMTP id s8mr922934otp.202.1581338932640; Mon, 10 Feb 2020 04:48:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581338932; cv=none; d=google.com; s=arc-20160816; b=RSdIbirsRDOBAPCqoIJWmgU4WmeG/pbjU59hoe3rXuK0E1Vi9Ie9r5dwjz6MSdr5t9 O4CfdMkMOQs7dPVo6RxwasmkaUtoFc1A6fDwaXxJBRk0gWVudOsTz4HVezCInoDUP0NR xj2NUWgsomjDMzZJeCnRGAw2aNQu1CSdQY0voAglr/XaOpfq2UaXQD5yDDNMVdqLRIz4 pQNlbHMnWJEhWI8By28smebrzqkyGKPyVBXp6fs+Z+MK7gmeryD3UjDqBRnCVovKzNhE l2xcuSV4leBAfLddea2X6sdy7cpxi4zAHS+hh/thEUEIjEzHC/1Fp/jRaZnQoZEjFl5e Uabg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qX9OPgF2hJGzOwMIHMi/nzjLcS7E3ndqIVTpebju7Fc=; b=Zu1OSGWmMkyNkykt8Q+L8/7LAxAxkoC1N5gWVZm58fDSVy8J82TxB/fUnNxHzquLfJ T6B3vDhlt16yhGGVGahhcQaON9NCt5HXtpnBCFBhLm0hLf9wmGuHwtG8Ajgec6Eo1tnt 0SDXF0STp+qABjTIBJcOGjY6JBXfntIRbFsSx5ShslnaPW8spyVsYNoJaG8yMIhvYcfA vN7CB2RsQy/J8QNg7hUhOSXbzrTFyJhIDaA5xPYaUzuLXli7hGsZjWpnWuPctv52b2Xw O+udfKB3Jsd5c1tsVy+8htmLW9vWXj2IKFlg2rWHTTUs7DFxhD/AB9bLC9Gzfcf5n6Vn nSeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uFX69bi/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73si120740oii.60.2020.02.10.04.48.41; Mon, 10 Feb 2020 04:48:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uFX69bi/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730786AbgBJMrp (ORCPT + 99 others); Mon, 10 Feb 2020 07:47:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:48026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730379AbgBJMoG (ORCPT ); Mon, 10 Feb 2020 07:44:06 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0455E20838; Mon, 10 Feb 2020 12:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338646; bh=XJ1roiFTYWm+63LJKnpN8lPcUwrfJbwEpPXZtnWvoKE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uFX69bi/9vY3yVaW7EkVLcGXvWhb6HBA1SeVR9owpAB0qQSxDQ2tvtOg7zpwIhCVZ LezIaxxSs2uiVNVCrvRFuGefA8KpVXdCMBXsTghRF66znmkpmBulaOSj0M5JAoTF9p 5Jcgn9H0EeqKkFWu/q2M9sIm8R07kogVO1MFPg6U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Voon Weifeng , "Tan, Tee Min" , Ong Boon Leong , "David S. Miller" Subject: [PATCH 5.5 334/367] net: stmmac: update pci platform data to use phy_interface Date: Mon, 10 Feb 2020 04:34:07 -0800 Message-Id: <20200210122453.616957766@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Voon Weifeng [ Upstream commit 909c1dde67c433f1e4122f2619cbd8ac370fcf0a ] The recent patch to support passive mode converter did not take care the phy interface configuration in PCI platform data. Hence, converting all the PCI platform data from plat->interface to plat->phy_interface as the default mode is meant for PHY. Fixes: 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") Signed-off-by: Voon Weifeng Tested-by: Tan, Tee Min Signed-off-by: Ong Boon Leong Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c @@ -96,7 +96,7 @@ static int stmmac_default_data(struct pc plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_GMII; + plat->phy_interface = PHY_INTERFACE_MODE_GMII; plat->dma_cfg->pbl = 32; plat->dma_cfg->pblx8 = true; @@ -220,7 +220,8 @@ static int ehl_sgmii_data(struct pci_dev { plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_SGMII; + plat->phy_interface = PHY_INTERFACE_MODE_SGMII; + return ehl_common_data(pdev, plat); } @@ -233,7 +234,8 @@ static int ehl_rgmii_data(struct pci_dev { plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_RGMII; + plat->phy_interface = PHY_INTERFACE_MODE_RGMII; + return ehl_common_data(pdev, plat); } @@ -261,7 +263,7 @@ static int tgl_sgmii_data(struct pci_dev { plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_SGMII; + plat->phy_interface = PHY_INTERFACE_MODE_SGMII; return tgl_common_data(pdev, plat); } @@ -361,7 +363,7 @@ static int quark_default_data(struct pci plat->bus_id = pci_dev_id(pdev); plat->phy_addr = ret; - plat->interface = PHY_INTERFACE_MODE_RMII; + plat->phy_interface = PHY_INTERFACE_MODE_RMII; plat->dma_cfg->pbl = 16; plat->dma_cfg->pblx8 = true; @@ -418,7 +420,7 @@ static int snps_gmac5_default_data(struc plat->bus_id = 1; plat->phy_addr = -1; - plat->interface = PHY_INTERFACE_MODE_GMII; + plat->phy_interface = PHY_INTERFACE_MODE_GMII; plat->dma_cfg->pbl = 32; plat->dma_cfg->pblx8 = true;