Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3696399ybv; Mon, 10 Feb 2020 04:53:53 -0800 (PST) X-Google-Smtp-Source: APXvYqz+ApAyprOvMvLwzCCvy4TeWuiIOLoKGncORTdV2US1s4uGrijo0z7Y7WqDxBrq9YvDDIiF X-Received: by 2002:a9d:7696:: with SMTP id j22mr1007393otl.188.1581339233291; Mon, 10 Feb 2020 04:53:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581339233; cv=none; d=google.com; s=arc-20160816; b=uk1861G6raxCx1HAztIWS/9LlOHYavgSbY+z+kXvAd+NcThoVaQLKvCx3WEt0daEnp jkpOb6LssVBPjUqzQuFkvw4eazruqDR7T/8z7cfZ8oUJNBtso/NRezrGlKoWSV1rvcfB D0ZE4cWblU4appKEzGPBGeJBrtJj5HrOtLBaR6f1giIzFeV1HgwWpqgCVkUp+WaKCgz1 OYDqrOrL/sDcA+ciCLG6uTNVSfFZpLEL5zfcUb/SPFsjEHY3W27bNRxeHhhVBlAkD9ah 8H7X7NuWArtF20a7mYbFi2uTeUz2ftvzMZARb2pevs1Qx4waW8Kza4DnFOZEFbEPhWXd 3Acw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wh0/QdDdk4zHw/Uzxc25BnPKf8KtWwWV+b3hQjhmn9E=; b=ggF8puJhITZEhQORYsglUVL0arCPYOtYhRvoDVU0RFi7lMfP+Vn/lqOw4VNTY3VT68 yYEe3vbF38cbtRY9fJ+U8A5mVG8YuiH3NGT6Q4G2/dJLdw0vL5jl4jmQBnP0VutaOPKj zT9jjsJB7BX3sH0UlW+7Cnilqjli2mKJEZf736FcRXoF38LybqrTQH1SJu7aA3yypgBq jMcB/DgbVo39jyufE677lJAnFA0MQkBowPmC2n9M19m+qu6BTjBXnT4zL/KLmHIPUaCd yBwCZM8MvAtI8w5Op97QlPFW3WfBfVtSBGKkY3y+rJKIfb+XRMOShx1IpCw3oVEt/g4O 5flA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pyyT74Gc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t9si155384otp.57.2020.02.10.04.53.41; Mon, 10 Feb 2020 04:53:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pyyT74Gc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728920AbgBJMwn (ORCPT + 99 others); Mon, 10 Feb 2020 07:52:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:46368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730217AbgBJMmT (ORCPT ); Mon, 10 Feb 2020 07:42:19 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B321C24650; Mon, 10 Feb 2020 12:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338538; bh=a5qcjP+kDxAn/qvCFH3xMONL9V4BA5fly2WYTF6a/e0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pyyT74GcZogXPr7phAu7m+Dz87pX48JG2JEvNMVGUw7q6dTJ7vv4wVxQWsNdD2bcj G+4Yc+dsoACg8nzX3DIOlSYM+uJYrC8FPdDP5N9dZ/Pobjl8vOGAIL3Yoyf63UHpU7 DP6weDC4DaL/TvuGHGO/5Y0JSxhzsohR++2ot6F8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vinicius Costa Gomes , "David S. Miller" Subject: [PATCH 5.5 338/367] taprio: Use taprio_reset_tc() to reset Traffic Classes configuration Date: Mon, 10 Feb 2020 04:34:11 -0800 Message-Id: <20200210122453.898485878@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vinicius Costa Gomes [ Upstream commit 7c16680a08ee1e444a67d232c679ccf5b30fad16 ] When destroying the current taprio instance, which can happen when the creation of one fails, we should reset the traffic class configuration back to the default state. netdev_reset_tc() is a better way because in addition to setting the number of traffic classes to zero, it also resets the priority to traffic classes mapping to the default value. Fixes: 5a781ccbd19e ("tc: Add support for configuring the taprio scheduler") Signed-off-by: Vinicius Costa Gomes Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sched/sch_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -1588,7 +1588,7 @@ static void taprio_destroy(struct Qdisc } q->qdiscs = NULL; - netdev_set_num_tc(dev, 0); + netdev_reset_tc(dev); if (q->oper_sched) call_rcu(&q->oper_sched->rcu, taprio_free_sched_cb);