Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3697879ybv; Mon, 10 Feb 2020 04:55:39 -0800 (PST) X-Google-Smtp-Source: APXvYqwSgVQNfj/WGyF1BlZv4FpubPtj5FFj1uQ3M6hjQpFo77hPYAPQaavO2pf+Ic02j54eMF70 X-Received: by 2002:aca:f517:: with SMTP id t23mr688921oih.160.1581339338933; Mon, 10 Feb 2020 04:55:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581339338; cv=none; d=google.com; s=arc-20160816; b=g+2WxUypiC5XYEQH7nZ5c10Bq2Ep1sPwwzPHBwb9hyTsUZW1nQbhtBq31RWBaBrOj7 feumom1J1Rl+1QeF/6Mcm7uIPqB5CKwCBYWnyWDmq+uQ7XsrSSbmTkKsBCaIo2TKw1rt YIf6gVHItvfvI+Adu/w9U2mth8F7RiKvu7u6HSTingVou05pI3CMlhGE5fz6w6wr4xer VIfu+msG703DF6x9h14Q+//8110EF2SC/8pMGsbUgmmUyjgB6iFaNUjSja+iomYRjxZK By1wJLO53MYD1ujlDJCJra3+RvOcVqQxR2DxAZqd8iPj8od19ZcQp6wMeXxtf7QS4fMB dfeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=d16IGg+Sandh8Kzc8Sv6JM24ELTyc26rv5zbM6OlnoI=; b=JFt6+0ci8pf7xfh4lVPHhfYkM8AUb3dnvNhjU2HErB4nJ6ZhCVZ14iHtXFDDfxEiB6 stlg9cOx9HjU1IheMyj6w93R3Noi1R1SrRSudUBZCj8ddEOZY5fwogIEmmHCNzIfiLDr z5XIBOsc/hgPfy43l7mQj+T/zpgxtdQO9duBxszxa1+Z7rETY59ovz9G+/fJ+I+s5aCv +YokW+o+C1y3yrp05BX6iSgbzilEFBQGHOblVYSNCHgkTREmNFZV1xO94OfJhLlOG26v yzP/WQFp3Q8oN/Y3XAb6DvebyO8kV2C6AN+rFXTSbu0ygPR2PooXNwKvS2uKYForWz6o iEBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="A/TGU23Z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16si159562otu.77.2020.02.10.04.55.26; Mon, 10 Feb 2020 04:55:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="A/TGU23Z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730047AbgBJMzY (ORCPT + 99 others); Mon, 10 Feb 2020 07:55:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:44888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730075AbgBJMlt (ORCPT ); Mon, 10 Feb 2020 07:41:49 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B229B2080C; Mon, 10 Feb 2020 12:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338508; bh=EoklstDWNnn2rWz0l7oezB9IjLDwq59jnrNWLRfUkFg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A/TGU23ZwtTK2L9YPJhG6cfR8RhGmg12oX+soGsU1pS7Ty8TSV+ZqBcgz34dpFG2a VHSMQzrU0RiNEWI+tE5zhyOsev0rdNZqDB8r2rQHOcn4wrHJZPDM4RSc46KH9kCD36 /G3LD7ORCluAUT7icZxulTTtnhKjiu5A7h4RNEw0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matti Vaittinen , Alexandre Belloni , Lee Jones Subject: [PATCH 5.5 311/367] mfd: bd70528: Fix hour register mask Date: Mon, 10 Feb 2020 04:33:44 -0800 Message-Id: <20200210122452.013434780@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matti Vaittinen commit 6c883472e1c11cb05561b6dd0c28bb037c2bf2de upstream. When RTC is used in 24H mode (and it is by this driver) the maximum hour value is 24 in BCD. This occupies bits [5:0] - which means correct mask for HOUR register is 0x3f not 0x1f. Fix the mask Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC") Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- include/linux/mfd/rohm-bd70528.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/mfd/rohm-bd70528.h +++ b/include/linux/mfd/rohm-bd70528.h @@ -317,7 +317,7 @@ enum { #define BD70528_MASK_RTC_MINUTE 0x7f #define BD70528_MASK_RTC_HOUR_24H 0x80 #define BD70528_MASK_RTC_HOUR_PM 0x20 -#define BD70528_MASK_RTC_HOUR 0x1f +#define BD70528_MASK_RTC_HOUR 0x3f #define BD70528_MASK_RTC_DAY 0x3f #define BD70528_MASK_RTC_WEEK 0x07 #define BD70528_MASK_RTC_MONTH 0x1f