Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3708345ybv; Mon, 10 Feb 2020 05:05:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyoYigv1aZO/KkV8oN8tlDsg9NVKnImve/CMBTZr3g9z4WHpbPQU1YFg6v8LC7lBLc4tJwA X-Received: by 2002:a9d:7593:: with SMTP id s19mr920298otk.219.1581339950815; Mon, 10 Feb 2020 05:05:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581339950; cv=none; d=google.com; s=arc-20160816; b=fDkSHpQP3OSanh+JGyFLOUDkmvfCJJqz6XtqO7voxNRi/nsuOqRUcSltQ9SFrDbT6u 6WNTOv68dJMqnhcv6ykqPV6GwUw24K8/u+YH0oTLvpOOKDUOtO0sq6VijyKqy1R3vmp+ p/v9r7l0wBBjyKiT/O2TqzF9k0tGEI9XjRO/JRzy6FIuzqIfTOhxLmVPepezgI1/UJwX SHbFXY5VDxmmQH/jAsMlyNI9rf1TYxx5QaXabwZazdUMb9tsWq9bpE9oTSinj4iSoG0I ugviAQ9Xe9v3SnU0wnvonKHqrIwf3ARoHXzLSNgfDLklIuU1/jv9jaaB+DRNfiTATPLe qE/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BTzNhdI8pz06VqL0eCCn9PrKu5U/Sh1Zv42uVPxvgp8=; b=iqWELNSqrIoBZsZ2NecoLyTnbfdDJjgv/eRTGq8ABiukG1OJEwfebGnXnR/3Cpihu3 MqS6aMrYazCKbFykGRm0Cjvd3n/nE1FgU+rsHVWiIvceEX785HpaSuyNWDKsmmXS3w0O ogqj4DZwCSm9xru38ozQODpiWurEBW2Yq1o92Mu159kL7cMsnBIq5r6i37+Kt6eCgdYC 8x+m/0N6SCv/jPaKTvxHaiZ4hBkKqFgCNSn1MRqQXuFgatGPzMos3HE4LFjcAYc9UcDP UAI37HXmfy42Hm7aXU3J7vGhYevFGFyyf/qP18iwCN/ubkmL76GFhpC7gClreWK0JmR2 txwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gi4dpEuW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8si168778oti.47.2020.02.10.05.05.38; Mon, 10 Feb 2020 05:05:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gi4dpEuW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729931AbgBJNDc (ORCPT + 99 others); Mon, 10 Feb 2020 08:03:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:40240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729715AbgBJMkX (ORCPT ); Mon, 10 Feb 2020 07:40:23 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD8352465D; Mon, 10 Feb 2020 12:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338423; bh=G4kgGGeoj+dWTzgCjehelOgG4stCoMbF9iSLP4XKNDQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gi4dpEuWKnj6G0WIPXs4GzszuAaslv5GkIIzaVecuCWeMIKh+HrFQ7WRjHDMpox5w F3YrBzdjP5Muy/2avR3mO1gKrST10nEyWKocWYWA1yVzexYNTW2DpPzx2iEjh6sh+j edZxEDrHZ1ypKvIUsapKM9otB2buIq/K5ziDR9xQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mikulas Patocka , Mike Snitzer Subject: [PATCH 5.5 143/367] dm crypt: fix GFP flags passed to skcipher_request_alloc() Date: Mon, 10 Feb 2020 04:30:56 -0800 Message-Id: <20200210122438.047237719@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mikulas Patocka commit 9402e959014a18b4ebf7558733076875808dd66c upstream. GFP_KERNEL is not supposed to be or'd with GFP_NOFS (the result is equivalent to GFP_KERNEL). Also, we use GFP_NOIO instead of GFP_NOFS because we don't want any I/O being submitted in the direct reclaim path. Fixes: 39d13a1ac41d ("dm crypt: reuse eboiv skcipher for IV generation") Cc: stable@vger.kernel.org # v5.4+ Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -717,7 +717,7 @@ static int crypt_iv_eboiv_gen(struct cry struct crypto_wait wait; int err; - req = skcipher_request_alloc(any_tfm(cc), GFP_KERNEL | GFP_NOFS); + req = skcipher_request_alloc(any_tfm(cc), GFP_NOIO); if (!req) return -ENOMEM;