Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3711489ybv; Mon, 10 Feb 2020 05:08:44 -0800 (PST) X-Google-Smtp-Source: APXvYqzlwp2X1O6iyeW+RZZ+UNjAJDGtmCs1rz8pJg0Xh5GGEpLpKdYlgTqwjF1HfbsXkKQxRzX/ X-Received: by 2002:a9d:6415:: with SMTP id h21mr1037440otl.152.1581340123859; Mon, 10 Feb 2020 05:08:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581340123; cv=none; d=google.com; s=arc-20160816; b=JpVVw75taYqDFZug7NpyJW1i0ZT9xwhjiKCXIgNx0TF+6zYlW0H08Lk9ddiMbZzkfi lcCKELhAZR2Rw3jjqkyfAwDMRZSoMUffVoriNiaEoB9WWxp7UxTz/QmqCdZFUPt6kdim wAFGxOCzS4U0m2DRZ3qfoUcFZgEvC99XkxBYR94iJxxy8HxmSVSsy+v3ekHolrTOoz9Y k+0E9O9vUIpYTIPLFNBmuUC9/3BzeFDs4rikGDFNo7lfikN0AcO13D3vDb3vb5CDmq3F QwLWMK1WbEQnJer6iMuAIZGm8J034TBv2DKb7zPpEwMNHwYfIcg+0zl7UHLsvgrIMCKt 1iFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NTLjXUd1SNmT0+sUh0gQmZWc823kghnK9ba5BtAcgvk=; b=PQUYXLWYRSu1/FI8Bezj/nD3H4xaSCbqr3w9gTL86aIHZcY+eMQCgCIJo8fu7iH90T /qSa3VHtifnB0VeOHBpztVrH9T8JSTJe6QNAeMuJItgEU+AIkYit+hchMrXIDWj+TGvI DlcdF52Kp6cWCHOComaoSLq9GRCYYMzOoTXjoseS2uvsIXSc/qvwYwIOTImAJ42MrAoN tr3AQpcnDUdZxc6L3uDlZdwjv5ulMepoPM0SCA8SXMC7xaCcxX0ddhj4avp69zmVYtnW C3H1RnJrZf2TlpWn6eL38klrl73K8p/e6l0gkDHrQxKMyAogK+3oCk2tbh2sQ0cqKAhP v36Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CR+Sqtdh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si141668oik.171.2020.02.10.05.08.31; Mon, 10 Feb 2020 05:08:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CR+Sqtdh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730283AbgBJNHV (ORCPT + 99 others); Mon, 10 Feb 2020 08:07:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:38212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729506AbgBJMjo (ORCPT ); Mon, 10 Feb 2020 07:39:44 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F08DA24684; Mon, 10 Feb 2020 12:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338384; bh=Ij0hfG6Hsb9nxUaFvyNt85tsg8GkDcEXtR5HNI+GKqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CR+SqtdhQTxfRx3aXgOdy5VWb3yQda44vJslLxEkTppM/UPqUuhq+quRkaNT+WIZl /tjprNiAzblcftplCi/OaKMHku/VJWXTCXQ8hq9aSliZmEGg+S+QlmIaioLyN5UjMy Lp+3G8QnFOAIOqwUTA04uVXcPFmDqzocFAcYZGV0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kevin Hao , Marc Zyngier Subject: [PATCH 5.5 065/367] irqdomain: Fix a memory leak in irq_domain_push_irq() Date: Mon, 10 Feb 2020 04:29:38 -0800 Message-Id: <20200210122430.096843550@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kevin Hao commit 0f394daef89b38d58c91118a2b08b8a1b316703b upstream. Fix a memory leak reported by kmemleak: unreferenced object 0xffff000bc6f50e80 (size 128): comm "kworker/23:2", pid 201, jiffies 4294894947 (age 942.132s) hex dump (first 32 bytes): 00 00 00 00 41 00 00 00 86 c0 03 00 00 00 00 00 ....A........... 00 a0 b2 c6 0b 00 ff ff 40 51 fd 10 00 80 ff ff ........@Q...... backtrace: [<00000000e62d2240>] kmem_cache_alloc_trace+0x1a4/0x320 [<00000000279143c9>] irq_domain_push_irq+0x7c/0x188 [<00000000d9f4c154>] thunderx_gpio_probe+0x3ac/0x438 [<00000000fd09ec22>] pci_device_probe+0xe4/0x198 [<00000000d43eca75>] really_probe+0xdc/0x320 [<00000000d3ebab09>] driver_probe_device+0x5c/0xf0 [<000000005b3ecaa0>] __device_attach_driver+0x88/0xc0 [<000000004e5915f5>] bus_for_each_drv+0x7c/0xc8 [<0000000079d4db41>] __device_attach+0xe4/0x140 [<00000000883bbda9>] device_initial_probe+0x18/0x20 [<000000003be59ef6>] bus_probe_device+0x98/0xa0 [<0000000039b03d3f>] deferred_probe_work_func+0x74/0xa8 [<00000000870934ce>] process_one_work+0x1c8/0x470 [<00000000e3cce570>] worker_thread+0x1f8/0x428 [<000000005d64975e>] kthread+0xfc/0x128 [<00000000f0eaa764>] ret_from_fork+0x10/0x18 Fixes: 495c38d3001f ("irqdomain: Add irq_domain_{push,pop}_irq() functions") Signed-off-by: Kevin Hao Signed-off-by: Marc Zyngier Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20200120043547.22271-1-haokexin@gmail.com Signed-off-by: Greg Kroah-Hartman --- kernel/irq/irqdomain.c | 1 + 1 file changed, 1 insertion(+) --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -1459,6 +1459,7 @@ int irq_domain_push_irq(struct irq_domai if (rv) { /* Restore the original irq_data. */ *root_irq_data = *child_irq_data; + kfree(child_irq_data); goto error; }