Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3712104ybv; Mon, 10 Feb 2020 05:09:15 -0800 (PST) X-Google-Smtp-Source: APXvYqw+LwnqpXRCASKSX9zOVxdk8Ny/pP2WtCIcdr5wnw6f7K5lWn3gh/Flj+lYxAIff+q+z0S0 X-Received: by 2002:a9d:545:: with SMTP id 63mr1015205otw.285.1581340155853; Mon, 10 Feb 2020 05:09:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581340155; cv=none; d=google.com; s=arc-20160816; b=x+4QNED2Io6JvQCMz/Alj/tc+3kDwUt9OLT+1LcNE9wSuW4zOIozLi/mllmGfuuGIg OOoaj9HD4NHHn/azMHnV1p92jUxPfgQdcmZEwM+gifSNYHEqtJKFBLgaBXkaSjd9qWd/ 8LXGZfej8XPm/Vbm8c4M45Of8T8wfhYRziUtIDbQTZldKsjQAViuuAeiodgGF166ZA4C 1xktPtevx/M6opXS3bPDXjmvS0OzHlEZhfY2MtpvOTXL28WsuE+lzbseNKHqmmdO+BAM lvR2mdcjStdyGeLa1sSzxuXvMxQLm9jxKApJuiyUUfL+L12UOjI0TEMK7yIEOrcnWj79 W+MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Va7PgEK7MvigrVdegpVLIUEN8/Aat9v0VjLLM4Eobf8=; b=jKOG86J/9Qx69Ojpvmon6H5TlrEr3Q4x+Xek2oZbN67u+bp/TnePwu/CRDxpyO1ER5 v6pysDeB3TUw6C20mkuVLP4yBUwEACotV4fgRbV4GCkmCk8i2N1F9eEQiPLKKpNyEYR2 +HbHtNOf1+ZBNKgOaEw8BYcAk4bc5AZ+Pv6U2ObaickDMi0yS6pHRkyGgvn+l2xBfLXs /zQUeyMyzlAUyeLoa/2FUoUJtqxLL4KMkmNmiuMe/dGU3dP0+gUgRHM35cAGSFAdZ+SU raQmzuaaLtqpFA21yJRWgyGlDMoMoB4WRQXofTFuolv5mKsSzL5QVWWsOh/4I4OBrbHy nOTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nNhnxp2E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k128si140527oih.274.2020.02.10.05.09.03; Mon, 10 Feb 2020 05:09:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nNhnxp2E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730054AbgBJNI5 (ORCPT + 99 others); Mon, 10 Feb 2020 08:08:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:36950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728272AbgBJMj0 (ORCPT ); Mon, 10 Feb 2020 07:39:26 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64E9920733; Mon, 10 Feb 2020 12:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338365; bh=dXwgEZi9yEiAY8CcKdIFfujGIGV82fYsTMl5apGTT+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nNhnxp2EO1dLRGKgCngWTpA6UtZgeZ7Ljqk6y1aU5yYZCKabDhSsF13t4WrrEYwNi nEK4pmai+FE+D/Mfso1bQ4eQ43yarq3uuE8fPmCLWtKC42lvjzBKvgGgZaEeOUoX/K uTuIz+QjnwVPrxJO5V8YagqlTLg+8XUDf1NfAi+Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Chan , Jakub Kicinski Subject: [PATCH 5.5 009/367] bnxt_en: Fix TC queue mapping. Date: Mon, 10 Feb 2020 04:28:42 -0800 Message-Id: <20200210122424.695798599@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Chan [ Upstream commit 18e4960c18f484ac288f41b43d0e6c4c88e6ea78 ] The driver currently only calls netdev_set_tc_queue when the number of TCs is greater than 1. Instead, the comparison should be greater than or equal to 1. Even with 1 TC, we need to set the queue mapping. This bug can cause warnings when the number of TCs is changed back to 1. Fixes: 7809592d3e2e ("bnxt_en: Enable MSIX early in bnxt_init_one().") Signed-off-by: Michael Chan Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -7892,7 +7892,7 @@ static void bnxt_setup_msix(struct bnxt int tcs, i; tcs = netdev_get_num_tc(dev); - if (tcs > 1) { + if (tcs) { int i, off, count; for (i = 0; i < tcs; i++) {