Date: Mon, 6 Feb 2006 16:21:12 -0800 (PST)
From: Christoph Lameter <clameter@engr.sgi.com>
To: Andrew Morton <akpm@osdl.org>
cc: Ravikiran G Thirumalai <kiran@scalex86.org>, linux-kernel@vger.kernel.org,
       manfred@colorfullife.com, shai@scalex86.org,
       alok.kataria@calsoftinc.com, sonny@burdell.org,
       Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from
 cahep->spinlock to l3 lock
In-Reply-To: <20060206153008.361202e1.akpm@osdl.org>
Message-ID: <Pine.LNX.4.62.0602061610530.19350@schroedinger.engr.sgi.com>
References: <20060203205341.GC3653@localhost.localdomain>
 <20060203140748.082c11ee.akpm@osdl.org> <Pine.LNX.4.62.0602031504460.2517@schroedinger.engr.sgi.com>
 <20060204010857.GG3653@localhost.localdomain> <20060204012800.GI3653@localhost.localdomain>
 <20060204014828.44792327.akpm@osdl.org> <20060206225117.GB3578@localhost.localdomain>
 <20060206153008.361202e1.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 886
Lines: 21

On Mon, 6 Feb 2006, Andrew Morton wrote:

> > Actually, it does not protect much anymore.  Here's a cleanup+comments
> > patch (against current mainline).
> 
> This is getting scary.  Manfred, Christoph, Pekka: have you guys taken a
> close look at what's going on in here?

I looked at his patch and he seems to be right. Most of the kmem_cache 
structure is established at slab creation. Updates are to the debug 
counters and to nodelists[] during node online/offline and to array[] 
during cpu online/offline. The chain mutex is used to protect the 
setting of the tuning parameters. I still need to have a look at the 
details though.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/