Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ASoC: dmaengine_pcm: Consider DMA cache caused delay in
 pointer callback
To:     Mark Brown <broonie@kernel.org>
CC:     Takashi Iwai <tiwai@suse.de>, <lgirdwood@gmail.com>,
        <tiwai@suse.com>, <perex@perex.cz>, <lars@metafoo.de>,
        <alsa-devel@alsa-project.org>, <vkoul@kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200210140423.10232-1-peter.ujfalusi@ti.com>
 <s5hmu9qfrq7.wl-tiwai@suse.de> <15c7df10-cf9f-109c-3cbf-e73af7f4f66a@ti.com>
 <20200210143717.GO7685@sirena.org.uk>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <8b48b17d-3751-c027-7b66-fbea3b5a412f@ti.com>
Date:   Mon, 10 Feb 2020 16:59:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20200210143717.GO7685@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 10/02/2020 16.37, Mark Brown wrote:
> On Mon, Feb 10, 2020 at 04:28:44PM +0200, Peter Ujfalusi wrote:
>> On 10/02/2020 16.21, Takashi Iwai wrote:
> 
>>>>  	delay += codec_delay;
>>>>  
>>>> -	runtime->delay = delay;
>>>> +	runtime->delay += delay;
> 
>>> Is it correct?
>>> delay already takes runtime->delay as its basis, so it'll result in a
>>> double.
> 
>> The delay here is coming from the DAI and the codec.
>> The runtime->delay hold the PCM (DMA) caused delay.
> 
> I think Takashi's point here (and a query I have) is that we end up with
> 
> 	delay = runtime->delay;
> 	delay += stuff;
> 	runtime->delay += delay;
> 
> which is equivalent to
> 
> 	runtime->delay = (runtime->delay * 2) + stuff;
> 
> and that's a bit surprising.

I see, I have missed what
9fb4c2bf130b ASoC: soc-pcm: Use delay set in component pointer function

did.
the soc-pcm part of the patch can be dropped then.

- P?ter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki