Date: Mon, 6 Feb 2006 16:44:10 -0800
From: Andrew Morton <akpm@osdl.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: olh@suse.de, davej@redhat.com, linux-kernel@vger.kernel.org, pavel@suse.cz,
       benh@kernel.crashing.org
Subject: Re: [PATCH] Fix build failure in recent pm_prepare_* changes.
Message-Id: <20060206164410.2c7d3f49.akpm@osdl.org>
In-Reply-To: <200602070057.26925.rjw@sisk.pl>
References: <200602032312.k13NCDAc012658@hera.kernel.org>
	<200602061603.29989.rjw@sisk.pl>
	<20060206113809.51c230ba.akpm@osdl.org>
	<200602070057.26925.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 28

"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > > --- linux-2.6.16-rc1-mm5.orig/drivers/macintosh/via-pmu.c
> > > +++ linux-2.6.16-rc1-mm5/drivers/macintosh/via-pmu.c
> > > @@ -2070,6 +2070,14 @@ restore_via_state(void)
> > >  	out_8(&via[IER], IER_SET | SR_INT | CB1_INT);
> > >  }
> > >  
> > > +#if defined(CONFIG_VT) && defined(CONFIG_VT_CONSOLE)
> > > +extern int pm_prepare_console(void);
> > > +extern void pm_restore_console(void);
> > > +#else
> > > +static int pm_prepare_console(void) { return 0; }
> > > +static void pm_restore_console(void) {}
> > > +#endif
> > > +
> > 
> > These should be in a header file.  Presumably one which
> > kernel/power/power.h includes, too.
> 
> Then I think I should move all that to include/linux/suspend.h.

Sounds sane.  Or <linux/console.h>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/