Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ASoC: dmaengine_pcm: Consider DMA cache caused delay in
 pointer callback
To:     Takashi Iwai <tiwai@suse.de>
CC:     <broonie@kernel.org>, <lgirdwood@gmail.com>, <tiwai@suse.com>,
        <perex@perex.cz>, <lars@metafoo.de>, <alsa-devel@alsa-project.org>,
        <vkoul@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200210140423.10232-1-peter.ujfalusi@ti.com>
 <s5hmu9qfrq7.wl-tiwai@suse.de> <15c7df10-cf9f-109c-3cbf-e73af7f4f66a@ti.com>
 <s5hk14ufqx9.wl-tiwai@suse.de>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <084c2d48-96dd-4d57-84f9-f02204cfbece@ti.com>
Date:   Mon, 10 Feb 2020 17:01:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <s5hk14ufqx9.wl-tiwai@suse.de>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 10/02/2020 16.38, Takashi Iwai wrote:
> On Mon, 10 Feb 2020 15:28:44 +0100,
> Peter Ujfalusi wrote:
>>
>> Hi Takashi,
>>
>>>> --- a/sound/soc/soc-pcm.c
>>>> +++ b/sound/soc/soc-pcm.c
>>>> @@ -1151,7 +1151,7 @@ static snd_pcm_uframes_t soc_pcm_pointer(struct snd_pcm_substream *substream)
>>>>  	}
>>>>  	delay += codec_delay;
>>>>  
>>>> -	runtime->delay = delay;
>>>> +	runtime->delay += delay;
>>>
>>> Is it correct?
>>> delay already takes runtime->delay as its basis, so it'll result in a
>>> double.
>>
>> The delay here is coming from the DAI and the codec.
>> The runtime->delay hold the PCM (DMA) caused delay.
> 
> Well, let's take a look at soc_pcm_pointer():
> 
> 	/* clearing the previous total delay */
> 	runtime->delay = 0;
> 
> 	offset = snd_soc_pcm_component_pointer(substream);
> 
> 	/* base delay if assigned in pointer callback */
> 	delay = runtime->delay;
> 
> 	delay += snd_soc_dai_delay(cpu_dai, substream);
> 
> 	for_each_rtd_codec_dai(rtd, i, codec_dai) {
> 		codec_delay = max(codec_delay,
> 				  snd_soc_dai_delay(codec_dai, substream));
> 	}
> 	delay += codec_delay;
> 
> 	runtime->delay = delay;
> 
> So, the code reads the current runtime->delay and saves it as delay
> variable.  Then it adds the max delay from codec DAIs, and stores back
> to runtime->delay.
> 
> If we change the last line to
> 	runtime->delay += delay;
> it'll add to the already existing value again, so it'll be doubly if
> runtime->delay was non-zero beforehand.

Yes, you are right.
The change is added by
9fb4c2bf130b ASoC: soc-pcm: Use delay set in component pointer function

which I have missed, apparently.

> That said, judging from the code, I believe the current soc-pcm.c code
> needs no change.

Yes, there is no need to change soc-pcm.

> 
> 
> thanks,
> 
> Takashi
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki