Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain'
 forward declaration
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     linux-kernel@vger.kernel.org,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        linux-arm-kernel@lists.infradead.org
References: <20200207114913.3052-1-dietmar.eggemann@arm.com>
 <20200207154855.GA5529@bogus>
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <e52903f6-4515-011e-b095-b30f347e3124@arm.com>
Date:   Mon, 10 Feb 2020 16:20:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200207154855.GA5529@bogus>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/02/2020 16:48, Sudeep Holla wrote:
> On Fri, Feb 07, 2020 at 12:49:13PM +0100, Dietmar Eggemann wrote:
>> The sched domain pointer argument from topology_get_freq_scale() and
>> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
>> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
>> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
>> from arch_scale_cpu_capacity()").
>>
>> So the 'struct sched_domain' forward declaration is no longer needed.
>> Remove it.
>>
>> W/o the sched domain pointer argument the storage class and inline
>> definition as well as the return type, function name and parameter list
>> fit all into one line.
> 
> Looks simple and good to me. I don't want to ask you split the patch as
> $subject indicates only one of the 2 changes in the patch. I am fine with
> it as it but if anyone else shout for that, go for the split.
> 
> Either way,
> 
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> 
> You have not added Greg who generally picks up the patch. Can you repost
> with him in cc and my reviewed-by so that he can pick it up.

Will do. I'll keep the patch like it is. Thanks for the review!