Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH next] xprtrdma: make the symbol
 'xprt_rdma_slot_table_entries' static
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20200210073927.8769-1-chenwandun@huawei.com>
Date:   Mon, 10 Feb 2020 11:08:57 -0500
Cc:     Bruce Fields <bfields@fieldses.org>,
        trond.myklebust@hammerspace.com,
        Anna Schumaker <Anna.Schumaker@Netapp.com>,
        davem@davemloft.net, kuba@kernel.org,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4A340D82-3FDF-415E-9C60-E8A915757C6A@oracle.com>
References: <20200210073927.8769-1-chenwandun@huawei.com>
To:     Chen Wandun <chenwandun@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi-

The Fixes: tag seems incorrect to me.


> On Feb 10, 2020, at 2:39 AM, Chen Wandun <chenwandun@huawei.com> =
wrote:
>=20
> Fix the following sparse warning:
> net/sunrpc/xprtrdma/transport.c:71:14: warning: symbol =
'xprt_rdma_slot_table_entries' was not declared. Should it be static?
>=20
> Fixes: 86c4ccd9b92b ("xprtrdma: Eliminate struct =
rpcrdma_create_data_internal")

86c4ccd9b92b correctly makes xprt_rdma_slot_table_entries a
global variable. This later commit (in v5.6-rc1)

7581d90109ca ("xprtrdma: Refactor initialization of =
ep->rep_max_requests")

should have changed xprt_rdma_slot_table_entries back to a static.

I'm not sure what the call is on sparse warnings these days, but
it doesn't seem like this clean up should be backported to stable.=20
Should Fixes: be removed?


> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> ---
> net/sunrpc/xprtrdma/transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/sunrpc/xprtrdma/transport.c =
b/net/sunrpc/xprtrdma/transport.c
> index 3cfeba68ee9a..14c2a852d2a1 100644
> --- a/net/sunrpc/xprtrdma/transport.c
> +++ b/net/sunrpc/xprtrdma/transport.c
> @@ -68,7 +68,7 @@
>  * tunables
>  */
>=20
> -unsigned int xprt_rdma_slot_table_entries =3D RPCRDMA_DEF_SLOT_TABLE;
> +static unsigned int xprt_rdma_slot_table_entries =3D =
RPCRDMA_DEF_SLOT_TABLE;
> unsigned int xprt_rdma_max_inline_read =3D RPCRDMA_DEF_INLINE;
> unsigned int xprt_rdma_max_inline_write =3D RPCRDMA_DEF_INLINE;
> unsigned int xprt_rdma_memreg_strategy		=3D =
RPCRDMA_FRWR;
> --=20
> 2.17.1

--
Chuck Lever