Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 0/4] perf tools: Fix kmap handling
To:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>
References: <20200210143218.24948-1-jolsa@kernel.org>
From:   Kim Phillips <kim.phillips@amd.com>
Message-ID: <7de7aa09-d59b-3e98-6289-d497aa0496d4@amd.com>
Date:   Mon, 10 Feb 2020 10:47:11 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <20200210143218.24948-1-jolsa@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 56fe4ccb-241f-4c97-fcec-08d7ae48e058
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2020 16:47:12.3199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QB5r6HnZLzJrTmWEd72MH8A68wWBoeHh0dFfl7q4AhweeMDQniH1vVvQgoEZIN2SrBL79IdoP8s4k2PWkYVVuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2608
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/10/20 8:32 AM, Jiri Olsa wrote:
> hi,
> Ravi Bangoria reported crash in perf top due to wrong kmap
> objects management, this patchset should fix that.
> 
> thanks,
> jirka
> 
> 
> ---
> Jiri Olsa (4):
>       perf tools: Mark modules dsos with kernel type
>       perf tools: Mark ksymbol dsos with kernel type
>       perf tools: Fix map__clone for struct kmap
>       perf tools: Move kmap::kmaps setup to maps__insert
> 
>  tools/perf/util/machine.c | 24 ++++++++++--------------
>  tools/perf/util/map.c     | 17 ++++++++++++++++-
>  2 files changed, 26 insertions(+), 15 deletions(-)
> 

This series fixes a segmentation fault I was seeing on a
couple of AMD systems, so:

Tested-by: Kim Phillips <kim.phillips@amd.com>

Thanks,

Kim

Thread 259 "perf" received signal SIGSEGV, Segmentation fault.
                                                              [Switching to Thread 0x7fff3b7b6700 (LWP 13241)]
__map__is_kernel (map=0x7fffd80098d0) at util/map.c:244
244		return machine__kernel_map(map__kmaps((struct map *)map)->machine) == map;
(gdb) bt
#0  __map__is_kernel (map=0x7fffd80098d0) at util/map.c:244
#1  0x000055555575d756 in perf_event__process_sample (machine=<optimized out>, sample=0x7fff3b7b5710, 
    evsel=0x555555ef9dd0, event=<optimized out>, tool=0x7fffffff8660) at builtin-top.c:799
#2  deliver_event (qe=<optimized out>, qevent=<optimized out>) at builtin-top.c:1192
#3  0x0000555555831f81 in do_flush (show_progress=false, oe=0x7fffffff8960) at util/ordered-events.c:244
#4  __ordered_events__flush (oe=oe@entry=0x7fffffff8960, how=how@entry=OE_FLUSH__TOP, timestamp=timestamp@entry=0)
    at util/ordered-events.c:323
#5  0x00005555558328df in __ordered_events__flush (timestamp=<optimized out>, how=<optimized out>, oe=<optimized out>)
    at util/ordered-events.c:342
#6  ordered_events__flush (oe=oe@entry=0x7fffffff8960, how=how@entry=OE_FLUSH__TOP) at util/ordered-events.c:341
#7  0x000055555575d0f1 in process_thread (arg=0x7fffffff8660) at builtin-top.c:1104
#8  0x00007ffff7bbd6db in start_thread (arg=0x7fff3b7b6700) at pthread_create.c:463
#9  0x00007ffff5d9788f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) p map
$1 = (const struct map *) 0x7fffd80098d0