Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3967161ybv; Mon, 10 Feb 2020 09:42:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxFeJOnzWFMWcWlDMTptN7m4XVjgn3to0+6NnV8MqCpyrQxqAnzEHweKDqK5LMQB5ppjwki X-Received: by 2002:a05:6830:1d93:: with SMTP id y19mr1955178oti.350.1581356544936; Mon, 10 Feb 2020 09:42:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581356544; cv=none; d=google.com; s=arc-20160816; b=X1aJFg8V3/uFoUKQUgwOinXTmX5VJqu7bJ4D7Bz5esv9/qD4vN2t6+2EK+vSPwEJ7B n/ixgm66IoTnawdO1LnO1UZanqgIfhPWRpO6cFmJdrkhkzn7iVioiVrxZRYHdHVXW6iL P33vpJPJyPPLZCjJ91VZuuSGa7zUUq5oPEalIEZXutZBKsoWKgouJQvypb3BRndilHOs +1ewGdJbIXTtM4h/ojTajZM5qYOWmH7lKVUXOt+m97DbAQP9aIIQDtlw+hzLdfBSTMTj HmoNypxEFX4M5H7qoAA/vwwKPCH2SOYkd8hTb65JLXO1SgWuhqvaPRBxuLlLzcJDCaiw 47jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=3gIUz/+oLLuaq19t30k8Jz+s5aA2PVpnAzXQO10cT/Y=; b=ZOO54QF/XtuPiK3ThWT8nn8uQYA46CWWNbbi8BFYL7rCbJiIiwL2Ctv+uD2TesrYPU W/uoPS6knNksRbP8qgEPYbbuje4e3Cy/FimUIhkZWuHycIsHR5U8+/nO5HbRIlaXakOM gT/jV80je9APsfZwCxqoaKS8TFEsAfPdXALUUruL1uXjuUxzdQi9pgzlIdXzZahcPpMb tNL3NJcd+3khPOW0iwLzYXvlA9+qjol8Osu78L9v0OqAqSkJpXN7luMW5DU0pwQrMHhm SIz9f3qotI/hNees+dqvRpFQgcKZXE9uCbTOknGPQzzGTWYlcK/ooLpo7Gi8hJZXeDWA XAsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FQ5SjqjI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si506459otn.35.2020.02.10.09.42.13; Mon, 10 Feb 2020 09:42:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FQ5SjqjI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728151AbgBJRlE (ORCPT + 99 others); Mon, 10 Feb 2020 12:41:04 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45536 "EHLO mail-wr1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728133AbgBJRlD (ORCPT ); Mon, 10 Feb 2020 12:41:03 -0500 Received: by mail-wr1-f50.google.com with SMTP id g3so7783167wrs.12 for ; Mon, 10 Feb 2020 09:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3gIUz/+oLLuaq19t30k8Jz+s5aA2PVpnAzXQO10cT/Y=; b=FQ5SjqjI8mESjcAV3hk0fQYB1DIjyI3CqJt/Aw53H9qwncQV+lCBRMSjQ9ez4AuPS9 TO7MkvREuIQeW/8B7MTc602yDlTEDGJeJW2aW15lFEJSUDTv2cwNH3coJVWJL3uztvdQ 8eHriud893T21Xf6LGypKFQcYCVPSKUIVcn9fWTNO9j2jF7Gi+iZQB+cDdbI9YZ6YoZP CEWpAt/4hPKW5geh6ytp1UpQN70S1ciZz061CDJL/aboGKgm4pnl8PidJ06uNY+3yli9 DN8AeGMPwJZDOSEWRrpTIa0PI6WclosM+d3+AeBamTiIZPLsF35gyimD/PAgQIksG9ab r2iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3gIUz/+oLLuaq19t30k8Jz+s5aA2PVpnAzXQO10cT/Y=; b=Y2fBOT0FKVUVDFgqUP7PTPW8h6Zrpp8sqW2v3oUAbfto6r0PD4/yiz7Oc+LmRClFcX jLa4M0RwIQm5EbMERzakSB1esk0wi3/K5llBsP+02N52uILbuBtZgjg1JlVLYZ6I1/Cp D138Du755OE2GYTt2ka2Mx0uP8sdoUDrHLF98MRNei3Wizd5ua49GBmTBxVgvkjI0wOW NiJoLmFZ0IL/rutVS/nK10nBVHaVTaXsTnl4axnWyfD4cC8s0TrsWJhus96Rx6SUDBzM i+7av6WtgLHePbjM1MAyyIY8cwO2H2axl4mIhlPEHMqFQEZbMQ/OYuRTXv4ElGPIwhux MfoA== X-Gm-Message-State: APjAAAVu9HndMxCZmSxy/UK2OEUDFMBRP4xjpwvnxC6+EmYNnFZsNCwv RSyRHH4wwKRZEnONLbEP0u9KtygNMVI= X-Received: by 2002:a5d:6292:: with SMTP id k18mr3078880wru.256.1581356461456; Mon, 10 Feb 2020 09:41:01 -0800 (PST) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id o15sm1401166wra.83.2020.02.10.09.41.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Feb 2020 09:41:00 -0800 (PST) Subject: Re: [PATCH v2 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais To: Adam Serbinski Cc: Mark Brown , Rob Herring , Bjorn Andersson , Andy Gross , Mark Rutland , Liam Girdwood , Patrick Lai , Banajit Goswami , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200207205013.12274-1-adam@serbinski.com> <20200209154748.3015-1-adam@serbinski.com> <20200209154748.3015-4-adam@serbinski.com> <616e3042f46cb7f052fc71e0ba4919a2@serbinski.com> From: Srinivas Kandagatla Message-ID: <5464ab87-f711-4aa6-3f22-f27bf4819998@linaro.org> Date: Mon, 10 Feb 2020 17:40:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <616e3042f46cb7f052fc71e0ba4919a2@serbinski.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2020 17:22, Adam Serbinski wrote: >>> >> >> Why are we adding exactly duplicate function of q6afe_mi2s_set_sysclk >> here? > > It isn't an exact duplicate. > > The reason I split off the new function is because the clock IDs for PCM > overlap/duplicate the clock IDs for TDM, yet the parameters to > q6afe_port_set_sysclk are not the same for PCM and TDM. > we should be able to use dai->id to make that decision. --srini > >>>   +    SND_SOC_DAPM_AIF_IN("QUAT_PCM_RX", NULL, >>> +                0, 0, 0, 0),