Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4003345ybv; Mon, 10 Feb 2020 10:24:03 -0800 (PST) X-Google-Smtp-Source: APXvYqy4B1MRHmxmP0L8lPmFbptHmq/xT3guXQG+V6QEPfHtni+AXyO4qT4H8Vqary/lxyn5H9kb X-Received: by 2002:aca:cf52:: with SMTP id f79mr224556oig.129.1581359043210; Mon, 10 Feb 2020 10:24:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581359043; cv=none; d=google.com; s=arc-20160816; b=cHPHa3Rs5QWCKO/gz9gjJo+Qij9CSdEotirPBlWhCWJ7fkF6B/dCVFYcIRplw/XJEW VmvR7mo/AbJJeNoODIcUWRkYTHHHltjdN+IZTKIdN9QFpcWN3ShgjFY//KRthyh35sQY z6J/aAcTqYLGNbq4CNvyvoKVyv+mt/FvfYAdwlJO+3IadY4eOs22Q3gtZ/uPffJTv1m5 ddHdChZi/zqfEkGzDX87HakWHtpUdRctTESCvWNeFhINv6ZjL4YhpIvb5+Qok5uJWsJE WNsPSFOm3yMtWUdHBdEoqUMpFGp5CBSmaXOWFcz419h4vFvm6J9IPfL++lL51F2bV3s5 dwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=epdo/vGAsKYb0aQAG/nzS7FA5k6ScggPEeYBNX3G8uA=; b=iJ4eN4tJhp3OTv+3ybr8OWps5aZmegp1N75+ENbqkk5FPgMTrEFSTNbAJrqmHpQXDW ZuYhFCGs0xEsJ2nn9OutidbgzmxK5Su/D9PT91+0NG3qh0VPDhPUDZrCi0puWoMsU4DA BMDkfjRmCE4chkCrQjmkEaENATRwYOJlG6I9quqC7ohAFetW7Wr6iXNYNk2qXd9lNIzN PnCty4qkzL/0WG+txNprnStj7/b9cnhL+JJo3tVutGN3th7/7VIWUg2F/XHUZPajaYk4 Ipakkr1iy/jbbZK18YqDoBUEcyBM/nvEgKvdm06YtqVW+DExB8JNRuieE8n0y1wtdLoU F2qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iiK85FFk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v18si520563otn.174.2020.02.10.10.23.50; Mon, 10 Feb 2020 10:24:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iiK85FFk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbgBJSXi (ORCPT + 99 others); Mon, 10 Feb 2020 13:23:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:46764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbgBJSXi (ORCPT ); Mon, 10 Feb 2020 13:23:38 -0500 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E9CBB20838 for ; Mon, 10 Feb 2020 18:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359017; bh=t3Wks9ek7HdZAz6PJfkKNyateIsqhC1vSgHRd0AbOp8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iiK85FFk1llSss7Y+WKoCQhsXOljBpzzUvKnMT33O/2Qb4MLgmoMZsRb/ugOpUOYA maNfzqkY1lGCPD+4umyoaW2df4LcCztXq2pR9ffElISHzDdNZQQxIkNB+SStreUyHy kWIfoQZJbKDHzCBnaTfwpRYalPutSU3oG+LzdppA= Received: by mail-wm1-f42.google.com with SMTP id g1so284536wmh.4 for ; Mon, 10 Feb 2020 10:23:36 -0800 (PST) X-Gm-Message-State: APjAAAWkm+OuHtzz7bCO51dr4+3bvrYaugVIxH1e6Ct3QweQkxz1T4WF hg1qChZEOYeIlbJZIiwZFIzZbWzpR7Amv7gkjw12CQ== X-Received: by 2002:a7b:cbcf:: with SMTP id n15mr262021wmi.21.1581359015424; Mon, 10 Feb 2020 10:23:35 -0800 (PST) MIME-Version: 1.0 References: <20200210150519.538333-1-gladkov.alexey@gmail.com> <20200210150519.538333-4-gladkov.alexey@gmail.com> In-Reply-To: <20200210150519.538333-4-gladkov.alexey@gmail.com> From: Andy Lutomirski Date: Mon, 10 Feb 2020 10:23:23 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 03/11] proc: move /proc/{self|thread-self} dentries to proc_fs_info To: Alexey Gladkov Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Kees Cook , Linus Torvalds , Oleg Nesterov , Solar Designer Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2020 at 7:06 AM Alexey Gladkov wrote: > > This is a preparation patch that moves /proc/{self|thread-self} dentries > to be stored inside procfs fs_info struct instead of making them per pid > namespace. Since we want to support multiple procfs instances we need to > make sure that these dentries are also per-superblock instead of > per-pidns, The changelog makes perfect sense so far... > unmounting a private procfs won't clash with other procfs > mounts. This doesn't parse as part of the previous sentence. I'm also not convinced that this really involves unmounting per se. Maybe just delete these words.