Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4284246ybv;
        Mon, 10 Feb 2020 16:17:10 -0800 (PST)
X-Google-Smtp-Source: APXvYqxwUjbUidY/77M4u7Zk2fjDkEjYw9oMkdT7yNRvuq0AOaFTiRuaW9RhJAte2bvuetMWaf3/
X-Received: by 2002:a05:6808:b22:: with SMTP id t2mr1204627oij.40.1581380230179;
        Mon, 10 Feb 2020 16:17:10 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1581380230; cv=none;
        d=google.com; s=arc-20160816;
        b=olvBBSYzwuCr39C7LoWe4HiNIqX4GPA6edMeu6aPjOFRtf1S1qtwPyITLN+TzudANQ
         VFY0SSz4VIN3Y+HXOf/aSu4u7NPMQ3ydqeqwbY+YsjejbUn1JrN35h5Spxbozvo/+R5N
         rK4lUQCP23FNOpY8OWNdX1e+XNPlrHTbiTqjaplk/Wd0CQ0GzlmjlpHYW4laezsnNj3D
         orNkB/IpLRYjsHSR44VIcU8SAIv1IFCGjQr9nRtf9LU3wyT5z1tCEx2SMJS51Cd6fJwo
         IBx6V3CMeRUhemDUGVVxH+wX72fWbr89Sbl+yvwE34dN+1YQMFMzRzo+n4ByczULpTGX
         nuLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :mime-version:references:in-reply-to:message-id:date:subject:cc:to
         :from;
        bh=Q/jtf1QAQWUBdGa6x5cGwrQgIxtlzXz53YFDTgazJkU=;
        b=W7P2bbxL4qTDL8IdzN8nmM/+HNTj+B/pUPYz7Ge4wv3Jt1Fa9G+zxy3Xdu8rROWAPG
         jGpjSNGfjP6NyIPzjzdGO3JnifNKZTEqPTjb5E+Uu0M7zYvYSYT9QaSBS4EnIR3L5aBf
         KtGwM6du2wz0M4robhUAi+FhoUXpCWcIzirdGpZGc/DiyhmFapdPEavxwVCN2ieDS135
         B00naYNqZHBkbEUH7rK/SvbIwlH9LbCbmx2HHOoHDUlTkktZBJt0qhtvsfM8tw0NkIDf
         eUHJLcFvG0VwOiRyGKxCvuhGO0wuAPdeNus0yNfIBRgL6whFRKdaBBB/iXfsZpDtVW6e
         wB5g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=me0fYgFl;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a20si1006731otf.271.2020.02.10.16.16.58;
        Mon, 10 Feb 2020 16:17:10 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=me0fYgFl;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727681AbgBKAPl (ORCPT <rfc822;zcyberian@gmail.com> + 99 others);
        Mon, 10 Feb 2020 19:15:41 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:18802 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727599AbgBKAPk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Feb 2020 19:15:40 -0500
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e41f20f0004>; Mon, 10 Feb 2020 16:15:11 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Mon, 10 Feb 2020 16:15:38 -0800
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Mon, 10 Feb 2020 16:15:38 -0800
Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 11 Feb
 2020 00:15:38 +0000
Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend
 Transport; Tue, 11 Feb 2020 00:15:38 +0000
Received: from blueforge.nvidia.com (Not Verified[10.110.48.28]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121)
        id <B5e41f22a0009>; Mon, 10 Feb 2020 16:15:38 -0800
From:   John Hubbard <jhubbard@nvidia.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Chinner <david@fromorbit.com>,
        Ira Weiny <ira.weiny@intel.com>, Jan Kara <jack@suse.cz>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Jonathan Corbet <corbet@lwn.net>,
        =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Michal Hocko <mhocko@suse.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Shuah Khan <shuah@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Matthew Wilcox <willy@infradead.org>,
        <linux-doc@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v6 10/12] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage
Date:   Mon, 10 Feb 2020 16:15:34 -0800
Message-ID: <20200211001536.1027652-11-jhubbard@nvidia.com>
X-Mailer: git-send-email 2.25.0
In-Reply-To: <20200211001536.1027652-1-jhubbard@nvidia.com>
References: <20200211001536.1027652-1-jhubbard@nvidia.com>
MIME-Version: 1.0
X-NVConfidentiality: public
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1581380111; bh=Q/jtf1QAQWUBdGa6x5cGwrQgIxtlzXz53YFDTgazJkU=;
        h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer:
         In-Reply-To:References:MIME-Version:X-NVConfidentiality:
         Content-Transfer-Encoding:Content-Type;
        b=me0fYgFl3u2iBx6IZn3iJpA+e66CKBG24D5gmrYC2O4NljOdB6b3oRMXZ5qp2bUNQ
         BGstaMFqf4iW77usOMFnA/kbS80U+ZYS+MOIyX8H5bMiw7tSkkjiHwpqKbeu5Yj4F7
         n0plnAN4T/4Eg/2nOdux8CYkK8phzZ4QQWaKkfnylRU//a9phghQ1/A1HkuPK3CgEz
         WKQaD343+kGHlAIK4tn/giXH7g6OYSSU3/uo5edLLceViLXhkTOz2A4w5O1ALfvsIz
         QikSrwzENxjNN5a7TDLT6mFfTDe66pHyc+WwBXn3D8CadLaUxTWTD2gJLzQq7IoMd/
         R0f5qq1nmQoUQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It's good to have basic unit test coverage of the new FOLL_PIN
behavior. Fortunately, the gup_benchmark unit test is extremely
fast (a few milliseconds), so adding it the the run_vmtests suite
is going to cause no noticeable change in running time.

So, add two new invocations to run_vmtests:

1) Run gup_benchmark with normal get_user_pages().

2) Run gup_benchmark with pin_user_pages(). This is much like
the first call, except that it sets FOLL_PIN.

Running these two in quick succession also provide a visual
comparison of the running times, which is convenient.

The new invocations are fairly early in the run_vmtests script,
because with test suites, it's usually preferable to put the
shorter, faster tests first, all other things being equal.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/vm/run_vmtests | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftes=
ts/vm/run_vmtests
index a692ea828317..df6a6bf3f238 100755
--- a/tools/testing/selftests/vm/run_vmtests
+++ b/tools/testing/selftests/vm/run_vmtests
@@ -112,6 +112,28 @@ echo "NOTE: The above hugetlb tests provide minimal co=
verage.  Use"
 echo "      https://github.com/libhugetlbfs/libhugetlbfs.git for"
 echo "      hugetlb regression testing."
=20
+echo "--------------------------------------------"
+echo "running 'gup_benchmark -U' (normal/slow gup)"
+echo "--------------------------------------------"
+./gup_benchmark -U
+if [ $? -ne 0 ]; then
+	echo "[FAIL]"
+	exitcode=3D1
+else
+	echo "[PASS]"
+fi
+
+echo "------------------------------------------"
+echo "running gup_benchmark -b (pin_user_pages)"
+echo "------------------------------------------"
+./gup_benchmark -b
+if [ $? -ne 0 ]; then
+	echo "[FAIL]"
+	exitcode=3D1
+else
+	echo "[PASS]"
+fi
+
 echo "-------------------"
 echo "running userfaultfd"
 echo "-------------------"
--=20
2.25.0