Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table
To:     Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
        "guillaume.ligneul@gmail.com" <guillaume.ligneul@gmail.com>,
        Henry Shen <Henry.Shen@alliedtelesis.co.nz>,
        "jdelvare@suse.com" <jdelvare@suse.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
References: <20200205010657.29483-1-henry.shen@alliedtelesis.co.nz>
 <20200205010657.29483-2-henry.shen@alliedtelesis.co.nz>
 <44032203aa33817430cd120ddd540ec0baaa5f2d.camel@alliedtelesis.co.nz>
 <e8c2b347-5af2-e48c-0f9d-2a6860171171@roeck-us.net>
 <dfae85e86f5a75b462f4cc23a158f608ef368685.camel@alliedtelesis.co.nz>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <c8ed3023-3b99-fac7-8857-33c253c5f9b4@roeck-us.net>
Date:   Mon, 10 Feb 2020 21:34:45 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <dfae85e86f5a75b462f4cc23a158f608ef368685.camel@alliedtelesis.co.nz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/10/20 6:32 PM, Chris Packham wrote:
> On Mon, 2020-02-10 at 18:30 -0800, Guenter Roeck wrote:
>> On 2/10/20 6:21 PM, Chris Packham wrote:
>>> On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
>>>> Add the of_match_table.
>>>
>>> Needs your Signed-off-by line.
>>>
>>
>> ti,lm73 would also have to be documented as trivial device.
>>
> 
> Yes there's another patch for that. I'll work with Henry to send a v2
> series instead of individual patches.
> 
DT patches need to be separate patches, or you'll get a complaint from Rob.

On a side note, I don't see the actual patch on hwmon's patchwork,
and I don't recall being copied on it.

Guenter

>> Guenter
>>
>>>> ---
>>>>    drivers/hwmon/lm73.c | 10 ++++++++++
>>>>    1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
>>>> index 1eeb9d7de2a0..733c48bf6c98 100644
>>>> --- a/drivers/hwmon/lm73.c
>>>> +++ b/drivers/hwmon/lm73.c
>>>> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
>>>>    	return 0;
>>>>    }
>>>>    
>>>> +static const struct of_device_id lm73_of_match[] = {
>>>> +	{
>>>> +		.compatible = "ti,lm73",
>>>> +	},
>>>> +	{ },
>>>> +};
>>>> +
>>>> +MODULE_DEVICE_TABLE(of, lm73_of_match);
>>>> +
>>>>    static struct i2c_driver lm73_driver = {
>>>>    	.class		= I2C_CLASS_HWMON,
>>>>    	.driver = {
>>>>    		.name	= "lm73",
>>>> +		.of_match_table = lm73_of_match,
>>>>    	},
>>>>    	.probe		= lm73_probe,
>>>>    	.id_table	= lm73_ids,
>>
>>