Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] tools/perf/metricgroup: Fix printing event names of
 metric group with multiple events incase of overlapping events
To:     Jiri Olsa <jolsa@redhat.com>, Joe Perches <joe@perches.com>
Cc:     acme@kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Jin Yao <yao.jin@linux.intel.com>,
        Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
        Anju T Sudhakar <anju@linux.vnet.ibm.com>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>
References: <20200131052522.7267-1-kjain@linux.ibm.com>
 <20200206184510.GA1669706@krava>
 <51a4b570eb47e80801a460c89acf20d13a269600.camel@perches.com>
 <20200210121135.GI1907700@krava>
From:   kajoljain <kjain@linux.ibm.com>
Message-ID: <c168e38f-ee24-f02c-9510-912ef4d3d6b4@linux.ibm.com>
Date:   Tue, 11 Feb 2020 16:50:41 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200210121135.GI1907700@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2/10/20 5:41 PM, Jiri Olsa wrote:
> On Thu, Feb 06, 2020 at 10:58:12AM -0800, Joe Perches wrote:
>> On Thu, 2020-02-06 at 19:45 +0100, Jiri Olsa wrote:
>>> On Fri, Jan 31, 2020 at 10:55:22AM +0530, Kajol Jain wrote:
>>>
>>> SNIP
>>>
>>>>  				ev->metric_leader = metric_events[i];
>>>>  			}
>>>> +			j++;
>>>>  		}
>>>> +		ev = metric_events[i];
>>>> +		evlist_used[ev->idx] = true;
>>>>  	}
>>>>  
>>>>  	return metric_events[0];
>>>> @@ -160,6 +161,9 @@ static int metricgroup__setup_events(struct list_head *groups,
>>>>  	int ret = 0;
>>>>  	struct egroup *eg;
>>>>  	struct evsel *evsel;
>>>> +	bool evlist_used[perf_evlist->core.nr_entries];
>>>> +
>>>> +	memset(evlist_used, 0, perf_evlist->core.nr_entries);
>>>
>>> I know I posted this in the previous email, but are we sure bool
>>> is always 1 byte?  would sizeod(evlist_used) be safer?


Hi jiri,
     Yes you are right. We should use 'evlist_used' size itself.

>>>
>>> other than that it looks ok
>>>
>>> Andi, you're ok with this?
>>
>> stack declarations of variable length arrays are not
>> a good thing.
>>
>> https://lwn.net/Articles/749089/
>>
>> and
>>
>> 	bool evlist_used[perf_evlist->core.nr_entries] = {};


I am planning to use calloc and free that memory later in function 'metricgroup__setup_events'.
Something like this. 


+       bool *evlist_used;
+
+       evlist_used = (bool *)calloc(perf_evlist->core.nr_entries,
+                                    sizeof(bool));
+       if (!evlist_used) {
+               ret = -ENOMEM;
+               break;
+       }

Please let me know if its looking fine.

Thanks,
Kajol

> 
> hum, I think we already have few of them in perf ;-)
> thanks for the link
> 
> right, that initialization is of course much better, thanks
> 
> jirka
>