Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4831106ybv; Tue, 11 Feb 2020 04:20:14 -0800 (PST) X-Google-Smtp-Source: APXvYqwwxAXAWkFMzf0WAxa3EzSK+xf8jEfmSco5UgtDDupOqv7yav8Hk8+bGxJcRRV6D92h4bva X-Received: by 2002:a05:6808:99c:: with SMTP id a28mr2553100oic.164.1581423614427; Tue, 11 Feb 2020 04:20:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581423614; cv=none; d=google.com; s=arc-20160816; b=h0ECMbWJlJuCsu+ztGmdN23I4/wdsBNCk4p893Z/kYCL25W7FJsqof3uZwsoGOQ8Ts NSdb/EJ28fNx35RXomwI7auEEKp0Y9Na1DUxO1nhcEkXrTEmlhq7UtnUyqj3EErxQlfZ cNA4nPGiO6zITvL3VZgsaYGmdoDnNveaTkdOFzxbAW+NQ1gbyDMB2rNn7EQYkEoVJjGd Tg6L2dqpAbMh0zQFek0k646r0J+etXYf5gfnzVZ21MAWuhG30AGMMVlybHDe/8JULCOK sFhpuRdV2PJZjnN61H2gwZHJrRXuXl2ly5SB9wdkRBvbd6jZLK5gSmdkAyCcI/DBXEjW 3k6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:to:from:subject; bh=EOWqKmEQIiOjhZV6c8WiKcGKoW1SSNI8tott5iqZER0=; b=u8GEPxkvPb2A4lii04e8xtW6qc0z+Uz5DjdWvcEgHkViM57u6LXzoXg4fqqwvNCmkG JF6oFWjSbhwUWWfuHVaEyNBmP4tnlK7Dahuu3XR3Imf4mVM7ckTVGoaIFkdY7X9I232f BI3DkC3kxlSsid7jwDcF3ZL9dHFnLwcVPGw6kj1xiMmOlgytkYPQj4zPgg9N5CCKaGvq U+fFHlQo4MXdxfhKTolmPmajs/6Jv7tzYc7jk2J09+V8VrmIX1yrWZYw8F0HsNWSPD4d VhW3IxJ67HOS1S0EqClwKiDcmcxXn9CJT5ZXP0oPByfrvL7gPmKBB2szMcR9Btm5pzsb 8DvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e23si1638963oii.173.2020.02.11.04.20.01; Tue, 11 Feb 2020 04:20:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728365AbgBKLjK (ORCPT + 99 others); Tue, 11 Feb 2020 06:39:10 -0500 Received: from relay.sw.ru ([185.231.240.75]:54562 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727770AbgBKLjK (ORCPT ); Tue, 11 Feb 2020 06:39:10 -0500 Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104] helo=localhost.localdomain) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j1TsX-0007P4-KK; Tue, 11 Feb 2020 14:38:57 +0300 Subject: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() From: Kirill Tkhai To: akpm@linux-foundation.org, guro@fb.com, vvs@virtuozzo.com, ktkhai@virtuozzo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 11 Feb 2020 14:38:57 +0300 Message-ID: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break(). Fixes: bf8d5d52ffe8 "memcg: introduce memory.min" Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b1863de475fb..f6efe2348ba3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) continue; } memcg_memory_event(memcg, MEMCG_LOW); - break; + /* fallthrough */ case MEMCG_PROT_NONE: + mem_cgroup_iter_break(target_memcg, memcg); /* * All protection thresholds breached. We may * still choose to vary the scan pressure