Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm: Add missed mem_cgroup_iter_break() into
 shrink_node_memcgs()
To:     Vasily Averin <vvs@virtuozzo.com>, akpm@linux-foundation.org,
        guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain>
 <792e25d0-413f-28e0-1fd0-560523b63a45@virtuozzo.com>
From:   Kirill Tkhai <ktkhai@virtuozzo.com>
Message-ID: <ce5efea0-19b7-cd37-3b40-ba6b2cefd37c@virtuozzo.com>
Date:   Tue, 11 Feb 2020 14:48:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <792e25d0-413f-28e0-1fd0-560523b63a45@virtuozzo.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11.02.2020 14:46, Vasily Averin wrote:
> On 2/11/20 2:38 PM, Kirill Tkhai wrote:
>> Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break().
>>
>> Fixes: bf8d5d52ffe8 "memcg: introduce memory.min"
>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>> ---
>>  mm/vmscan.c |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index b1863de475fb..f6efe2348ba3 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
>>  				continue;
>>  			}
>>  			memcg_memory_event(memcg, MEMCG_LOW);
>> -			break;
> 
> It is not cycle break, it is switch/case break.

Oh, I missed this, thanks.
 
>> +			/* fallthrough */
>>  		case MEMCG_PROT_NONE:
>> +			mem_cgroup_iter_break(target_memcg, memcg);
>>  			/*
>>  			 * All protection thresholds breached. We may
>>  			 * still choose to vary the scan pressure
>>
>>