Received: by 2002:a17:90a:9307:0:0:0:0 with SMTP id p7csp5142126pjo; Tue, 11 Feb 2020 04:47:59 -0800 (PST) X-Google-Smtp-Source: APXvYqy1bq2Wtyx7+lONUUkbPFAqyUsfyXUHPDZ3/BtqETKWHZ0AML0yQBI3FW27BdTLutN8K6Z2 X-Received: by 2002:aca:4d06:: with SMTP id a6mr2761103oib.27.1581425279467; Tue, 11 Feb 2020 04:47:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581425279; cv=none; d=google.com; s=arc-20160816; b=xxsvR1gLcVJrIcXpX9kw0zRCCFEjdB7qGaTCElxH2LiVws27oPqGDV/1EDRZIqMAYa +Fk2VKKOeUPrzUJRw08ZAAXXn9af1Xe/kmQGhFZqoBDji88Ed+SecKvhmO+kApBlnaEX E3wTM1ss+qaLVOlfLXPKv2hqVx4l49wvnEMnX+k1LYXuPnToBqmbV8Td07XVknf4QOwa gf0f6dTiMpsBjBWA2/WCaBxTKHKYaMIuKZwb8jEfYQCz83nnK/xczdxxM7s4uZ4flz4z 5HsqB/ZwO58PSb5tCY7YJYfsMnXWB7qJ0goUDwa5kyYQD1vzfM8R+h/gmTBAquEGKcZ6 McMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=woIIGHW54ULqE9ENJaryfMQcckwSF0JpI2ZwNL+u9yQ=; b=VcMog4DiIxqINXpqyYsoa0CF6GpP9eNNIw5dmKX65us1WFtiDh6Zn4MIwFaO3GWhVq Uc5EOGr9jXYphZQArXboi/Pa8VOhb0KhGCSM3D74hIYxuhZ4JGtmrYJ0mCAcNzwHpD8s GE7H40ZRLSnyOumadZMHnR2Z4K0HTxuqTc8FeKGRQDOAMegBPr8GWOdENjGRNeOpK/iE E29E6cVTIWO6qDG0D2VwbsXiHcKo0v5B8qaKs0Fn2mlsoZ0t12ee/b/fZqbK5uZ4/Pzm 5Gknh9oTTJOAjy716vqkHqzaVxW/mUGvoqUqWmKs1bZYUOqf6EruKLO0sdALr9iJeulL PDIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e64si1552862oib.4.2020.02.11.04.47.47; Tue, 11 Feb 2020 04:47:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728777AbgBKMXx (ORCPT + 99 others); Tue, 11 Feb 2020 07:23:53 -0500 Received: from foss.arm.com ([217.140.110.172]:45028 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728540AbgBKMXx (ORCPT ); Tue, 11 Feb 2020 07:23:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 14B7D1FB; Tue, 11 Feb 2020 04:23:53 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DE723F6CF; Tue, 11 Feb 2020 04:23:52 -0800 (PST) Date: Tue, 11 Feb 2020 12:23:51 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Cc: Jeff Chang , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "matthias.bgg@gmail.com" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: MT6660 update to 1.0.8_G Message-ID: <20200211122351.GJ4543@sirena.org.uk> References: <1580787697-3041-1-git-send-email-richtek.jeff.chang@gmail.com> <20200210185121.GC14166@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1ou9v+QBCNysIXaH" Content-Disposition: inline In-Reply-To: X-Cookie: Hire the morally handicapped. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1ou9v+QBCNysIXaH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 11, 2020 at 02:04:42AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > What should I do is just apply them to be hard code into the driver? I ca= nnot use event a table to descript it like below? >=20 > static const struct codec_reg_val e4_reg_inits[] =3D { Doing what you've got here is hard coding it in the driver. --1ou9v+QBCNysIXaH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5CnNYACgkQJNaLcl1U h9CmmAf/f2m+iY01h2zxveePh8kLV67hfAIacGMZXGLIzsnhrSXN/FwdW1get7dG oG5R50Qosg/i9F2Ov0oqOGqJqtc039++uyXkbFR0gxSl5o7ixX5NlXLVRuqV/qWl KSmiv4UWKiDVGLu3ITfwdwcLU/0mu1++10XgspK4ZDrexG2sXJAJ4rUN/ntD0nz0 utsW2B0LoZyU5bNQ7qoSPMWQaRWbzIoSYlupXIF9exiO6c+Qh3AL1NSHzwcrAOrp px7Iu0pVaBC3lcaKw3IkDDcbSwzU+kGfl1WaMcQaHior5sQmZhrL1jlTXigvBLn0 8o8LXGIwL0xXh6O3XWKghL+taEW33w== =twZR -----END PGP SIGNATURE----- --1ou9v+QBCNysIXaH--