Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <a0f1570686e4cb99025d0c0b571f07a84d6467d9.1579004658.git.michal.simek@xilinx.com>
In-Reply-To: <a0f1570686e4cb99025d0c0b571f07a84d6467d9.1579004658.git.michal.simek@xilinx.com>
From:   Michal Simek <monstr@monstr.eu>
Date:   Tue, 11 Feb 2020 14:11:42 +0100
Message-ID: <CAHTX3dLd_0G3x-bXYSAcad=9-1f3+ujQt8+Nm=7MZ=KwYY7C_Q@mail.gmail.com>
Subject: Re: [PATCH] microblaze: Kernel parameters should be parsed earlier
To:     LKML <linux-kernel@vger.kernel.org>,
        Michal Simek <monstr@monstr.eu>, git <git@xilinx.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C3=BAt 14. 1. 2020 v 13:24 odes=C3=ADlatel Michal Simek <michal.simek@xili=
nx.com> napsal:
>
> Kernel command line should be parsed before mmu_init is called to be able
> to get for example cma sizes from command line. That's why call
> parse_early_param() earlier in machine_early_init().
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  arch/microblaze/kernel/setup.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/kernel/setup.c b/arch/microblaze/kernel/setu=
p.c
> index effed14eee06..34a082b17a01 100644
> --- a/arch/microblaze/kernel/setup.c
> +++ b/arch/microblaze/kernel/setup.c
> @@ -54,7 +54,6 @@ void __init setup_arch(char **cmdline_p)
>         *cmdline_p =3D boot_command_line;
>
>         setup_memory();
> -       parse_early_param();
>
>         console_verbose();
>
> @@ -177,6 +176,8 @@ void __init machine_early_init(const char *cmdline, u=
nsigned int ram,
>         /* Initialize global data */
>         per_cpu(KM, 0) =3D 0x1;   /* We start in kernel mode */
>         per_cpu(CURRENT_SAVE, 0) =3D (unsigned long)current;
> +
> +       parse_early_param();
>  }
>
>  void __init time_init(void)
> --
> 2.24.0
>

We found that this breaks earlycon support that's why v2 is necessary.

M


--=20
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs