Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] firmware/dmi: Report DMI Bios & EC firmware release
To:     Jean Delvare <jdelvare@suse.de>,
        Erwan Velu <erwanaliasr1@gmail.com>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Mattias Jacobsson <2pi@mok.nu>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "Darren Hart (VMware)" <dvhart@infradead.org>,
        Changbin Du <changbin.du@intel.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
References: <20200207083550.360461-1-e.velu@criteo.com>
 <20200211142112.649d7237@endymion>
From:   Erwan Velu <e.velu@criteo.com>
Message-ID: <ba5b88c9-f056-9375-d1fb-7832c76db29f@criteo.com>
Date:   Tue, 11 Feb 2020 14:31:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
In-Reply-To: <20200211142112.649d7237@endymion>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: criteo.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c6cedf8-0bea-4f72-5202-08d7aef6b4db
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2020 13:31:31.7543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2a35d8fd-574d-48e3-927c-8c398e225a01
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VCO4JUa/LHfvJuiBvcOo5JllSkxz8RL9qG4ZmLai8u7S/Aom0XMsjU4NdR8+tJt4ydsF2bA4HUvv8MxeiF78SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3981
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

No issue with that.

Thanks for applying.

Erwan,

On 11/02/2020 14:21, Jean Delvare wrote:
> On Fri,  7 Feb 2020 09:35:47 +0100, Erwan Velu wrote:
>> Some vendors like HPe or Dell, encode the release version of their BIOS
>> in the "System BIOS {Major|Minor} Release" fields of Type 0.
>>
>> This information is used to know which bios release actually runs.
>> It could be used for some quirks, debugging sessions or inventory tasks.
>>
>> A typical output for a Dell system running the 65.27 bios is :
>> 	[root@t1700 ~]# cat /sys/devices/virtual/dmi/id/bios_release
>> 	65.27
>> 	[root@t1700 ~]#
>>
>> Servers that have a BMC encode the release version of their firmware in the
>>   "Embedded Controller Firmware {Major|Minor} Release" fields of Type 0.
>>
>> This information is used to know which BMC release actually runs.
>> It could be used for some quirks, debugging sessions or inventory tasks.
>>
>> A typical output for a Dell system running the 3.75 bmc release is :
>>      [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/ec_firmware_release
>>      3.75
>>      [root@t1700 ~]#
>>
>> Signed-off-by: Erwan Velu <e.velu@criteo.com>
>> ---
>>   drivers/firmware/dmi-id.c       |  6 ++++++
>>   drivers/firmware/dmi_scan.c     | 30 ++++++++++++++++++++++++++++++
>>   include/linux/mod_devicetable.h |  2 ++
>>   scripts/mod/file2alias.c        |  2 ++
>>   4 files changed, 40 insertions(+)
>> (...)
> Applied, thanks. Note that I went for "efr" as the shortcut string for
> DMI_EC_FIRMWARE_RELEASE, which was your first choice and has my
> preference.
>