Date: Tue, 7 Feb 2006 09:55:54 +0200 (EET)
From: Pekka J Enberg <penberg@cs.Helsinki.FI>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
cc: Christoph Lameter <clameter@engr.sgi.com>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org, manfred@colorfullife.com,
       shai@scalex86.org, alok.kataria@calsoftinc.com, sonny@burdell.org
Subject: Re: [patch 2/3] NUMA slab locking fixes - move irq disabling from
 cahep->spinlock to l3 lock
In-Reply-To: <20060207075053.GA3664@localhost.localdomain>
Message-ID: <Pine.LNX.4.58.0602070953120.27102@sbz-30.cs.Helsinki.FI>
References: <20060203205341.GC3653@localhost.localdomain>
 <20060203140748.082c11ee.akpm@osdl.org> <Pine.LNX.4.62.0602031504460.2517@schroedinger.engr.sgi.com>
 <20060204010857.GG3653@localhost.localdomain> <20060204012800.GI3653@localhost.localdomain>
 <20060204014828.44792327.akpm@osdl.org> <20060206225117.GB3578@localhost.localdomain>
 <20060206153008.361202e1.akpm@osdl.org> <Pine.LNX.4.62.0602061610530.19350@schroedinger.engr.sgi.com>
 <Pine.LNX.4.58.0602070925180.25555@sbz-30.cs.Helsinki.FI>
 <20060207075053.GA3664@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 668
Lines: 16

On Mon, 6 Feb 2006, Ravikiran G Thirumalai wrote:
> IMHO, if you keep something around which is not needed, it might later get
> abused/misused.  And what would you add in as comments for the
> cachep->spinlock?  
> 
> Instead,  bold comments on cachep structure stating what all members are 
> protected by which lock/mutex should be sufficient no?

Yeah, I guess we can put the spinlock back if we ever need it.

			Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/