Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <66c67637ba097edb39efea7280989aaa20d710b1.camel@kernel.crashing.org>
Subject: Re: [PATCH v3 1/3] printk: Move console matching logic into a
 separate function
From:   Benjamin Herrenschmidt <benh@kernel.crashing.org>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Tue, 11 Feb 2020 16:26:42 +0100
In-Reply-To: <20200211142947.favkq56gkyexqkpg@pathway.suse.cz>
References: <e6b63bc26108c6e3645f9ea9e03aba38fd8b8464.camel@kernel.crashing.org>
         <20200211142947.favkq56gkyexqkpg@pathway.suse.cz>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-02-11 at 15:29 +0100, Petr Mladek wrote:
> > @@ -2626,6 +2627,60 @@ static int __init keep_bootcon_setup(char *str)
> > +     /*
> > +         * Some consoles, such as pstore and netconsole, can be enabled even
> > +         * without matching.
> > +         */
> 
> There are few lines in the patchset where the indentation is done
> by spaces instead of tabs. The above 3 lines are just one example.

Odd. Something must have gone wrong with my emacs config when I
switched laptops, I'll have a look thanks.

> I'll fix this when pushing. But please, be more careful next time ;-)
> I suggest to use some more clever editor that helps with code
> formatting.

I normally do :)

> Also I suggest to run ./scripts/checkpatch.pl on the patches
> before sending.

Yeah I never quite got that knack, I still keep forgetting ... the doom
of old habits, I didn't even when I was maintainer of arch/powerpc ...
oops :)

But yeah, I'll try to remember next time.

> Also the three patches were not send in a single thread so that
> it was harder to find all the pieces. I personally use:
> 
>     git format-patch --cover-letter origin/master -o some-dir
>     ./scripts/checkpatch.pl some-dir/*
>     $> edit some-dir/0000-*.patch
>     git send-email --smtp-server=... --to= --cc= ... some-dir/*

I usually do when it's more than a couple of patches but yeah, again,
bad old habits. Sorry about that.

Cheers,
Ben.