Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5193555ybv; Tue, 11 Feb 2020 10:56:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxcv5PnT5sbu3n6Q3lHIRsa4vImhc9qq62cJcTZbHC/oXj9eBMky5NtaE9nS2RWdkRIScfj X-Received: by 2002:a9d:64d8:: with SMTP id n24mr5946294otl.71.1581447418163; Tue, 11 Feb 2020 10:56:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581447418; cv=none; d=google.com; s=arc-20160816; b=islJguc9zG5olm4O6Mp1l0wEKJBGnAH99RbB5aHsaCKUX3VDK2RGekvFPyHfX2S9+X bBL3E5yJAN+Ap6DBOAPNzvKTCLmeWer3JNFW2hBsut/qVDQPr7jZECOPdoGAzeUI5ydy E9clIioDUp18lsL1+tV+vYPOBLjZqQEPuUoAiZvdH/KXyCskdcRzVp7fC4/yr83RZ1GO 7tK3km1VQ0YQPjB1J5vDlPLDq+UnFSyRzuBkrc+AWJEsY7BqXbGgj624iHT2oX+nogx1 aZ1fAab/CfSg2LjQaIczXJ3ap8aGoRZ3jnGbiwxWG/X1v4Sk5usVk0q4JISH3/Oj1A+c cjlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=+WDR7cnlSFkSrzqzCmQ6w67qDMEiw9qVoH+cY0ggWhc=; b=dBw6oKoLKNhqVQ3kRmCLc+lcWbn+cy8HnruesifHvQsvl1ZKrVrFGTaZ1hazu/RURD YXSKv/d50A0XhtEeVjJmU/54NYO8pEkHBh4/QsQTGfW66eJwVo9QmvWRySTHfeCdBYRf djWo2XOOhIFo6GvKHBJRC1hbJIEf7K9xJPBSaKCUYWUuW1cPVrYtSbf7HFLxlDkwowma osZnaghmIyIrXmqjs0kXw/bN5OBcaDn2qg8+7i1dY1gft4ARJqGK6NtM9Ef7PJ7UhwXQ oNULZLjHAyClY6bLaSI095lyWoafXBaXgpAZC6sJv4iMatjhUqalj8lUgIXKNhXAO9Tr LbKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si2175030otm.168.2020.02.11.10.56.46; Tue, 11 Feb 2020 10:56:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730881AbgBKQfs convert rfc822-to-8bit (ORCPT + 99 others); Tue, 11 Feb 2020 11:35:48 -0500 Received: from skedge04.snt-world.com ([91.208.41.69]:35414 "EHLO skedge04.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728295AbgBKQfs (ORCPT ); Tue, 11 Feb 2020 11:35:48 -0500 Received: from sntmail11s.snt-is.com (unknown [10.203.32.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge04.snt-world.com (Postfix) with ESMTPS id 9272667A884; Tue, 11 Feb 2020 17:35:44 +0100 (CET) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail11s.snt-is.com (10.203.32.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 11 Feb 2020 17:35:44 +0100 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1913.005; Tue, 11 Feb 2020 17:35:44 +0100 From: Schrempf Frieder To: Boris Brezillon , Schrempf Frieder , Jeff Kletsky , liaoweixiong , Miquel Raynal , Peter Pan CC: "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "Richard Weinberger" Subject: [PATCH 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Thread-Topic: [PATCH 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Thread-Index: AQHV4PlOqIGXKiRg80yCZpwMCvXHKw== Date: Tue, 11 Feb 2020 16:35:43 +0000 Message-ID: <20200211163452.25442-3-frieder.schrempf@kontron.de> References: <20200211163452.25442-1-frieder.schrempf@kontron.de> In-Reply-To: <20200211163452.25442-1-frieder.schrempf@kontron.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.17.1 x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 9272667A884.AE3E8 X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, git-commits@allycomm.com, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, peterpandong@micron.com, richard@nod.at X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf When writing the bad block marker to the OOB area the access mode should be set to MTD_OPS_RAW as it is done for reading the marker. Currently this only works because req.mode is initialized to MTD_OPS_PLACE_OOB (0) and spinand_write_to_cache_op() checks for req.mode != MTD_OPS_AUTO_OOB. Fix this by explicitly setting req.mode to MTD_OPS_RAW. Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Signed-off-by: Frieder Schrempf --- drivers/mtd/nand/spi/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 5d267a67a5f7..925db6269861 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -609,6 +609,7 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) .ooboffs = 0, .ooblen = 2, .oobbuf.out = marker, + .mode = MTD_OPS_RAW, }; int ret; -- 2.17.1