Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5328925ybv; Tue, 11 Feb 2020 13:37:15 -0800 (PST) X-Google-Smtp-Source: APXvYqzBMD07PJpzbe66Jmov/NDDVfZqk+QGhxv6SvLEzjl9gPXWaxkRTA/vyPklKhHTh547JVtw X-Received: by 2002:aca:484a:: with SMTP id v71mr4203745oia.39.1581457035475; Tue, 11 Feb 2020 13:37:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581457035; cv=none; d=google.com; s=arc-20160816; b=izDgPLJBpPIMhCldMJZgQQIjyCAInY5lFLDlu8sGiL+ZMNDaQJQWKXwDtDr+yp2L9g c9g1HqkS+immzMv9LGKjnPXOhjwkMpY3F0CZ5FtvdWVBjJKIX1IdXXLQAA+2Gfehz0nS 64T35JxNlilQ9GWsMGpG/00Oy06JR6OCWjuPz2HWRDzLPUWMtOQ/zAl1F3klOwXWJyQd x9wzZ2nV/A053WKZDrNOrO56Aj073nXDZsrACSMLUnmzXdmgQPBCs8zHz5KhBs8/1KoN JgX68OU8O4J9alkHpYDb//r2pi8ZlIXdO0pz+t1dFlBEmCJQyN+aO+/9rdNyeeXtDSyr sOTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DROjggmlTqFsjAJ6ruP1dSmEogKsS7IxwFCRuGyB8r4=; b=Qh0VvusWamzMjT8LsYZs0YjJhu0kg6CMye4t/RZdTAst4TLA9F43VvfPMKwV5ZkhfA Dc8ZrOHiN1IPMqmAHtoY54xRdjvLLWoq4rXgcxOaN8TFwt74t6TWmjhfj03D6YX7EYoS uZGhViQHLdDC307jdvQc1S1rjPIGWd2dXO76u5lg8TMqEdwg8GAP+rFFWOhypYF9QwsG jofJIjk0QIKPPOc65MR23ycPqXuEHh5JL+Pc4OG4unKf+0TQvtZVv2S2bvK4TeNwuDzs 21JPsAkRvVfi9GK6puY7Os6pPjLaOHAfXSpPgKJ6f2x9NOyy7YF8Uw0hF7+2kiY7HZgk odnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16si2536582otu.77.2020.02.11.13.37.03; Tue, 11 Feb 2020 13:37:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731430AbgBKSmB (ORCPT + 99 others); Tue, 11 Feb 2020 13:42:01 -0500 Received: from mga11.intel.com ([192.55.52.93]:7262 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728375AbgBKSmB (ORCPT ); Tue, 11 Feb 2020 13:42:01 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 10:42:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="433779485" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga006.fm.intel.com with ESMTP; 11 Feb 2020 10:42:00 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 58C64300FDE; Tue, 11 Feb 2020 10:42:00 -0800 (PST) Date: Tue, 11 Feb 2020 10:42:00 -0800 From: Andi Kleen To: Greg KH Cc: roman.sudarikov@linux.intel.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, bgregg@netflix.com, kan.liang@linux.intel.com, alexander.antonov@intel.com Subject: Re: [PATCH v5 3/3] perf =?iso-8859-1?Q?x86?= =?iso-8859-1?Q?=3A_Exposing_an_Uncore_unit_to_PMON_for_Intel_Xeon?= =?iso-8859-1?Q?=AE?= server platform Message-ID: <20200211184200.GA302770@tassilo.jf.intel.com> References: <20200211161549.19828-1-roman.sudarikov@linux.intel.com> <20200211161549.19828-4-roman.sudarikov@linux.intel.com> <20200211171544.GA1933705@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211171544.GA1933705@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 09:15:44AM -0800, Greg KH wrote: > On Tue, Feb 11, 2020 at 07:15:49PM +0300, roman.sudarikov@linux.intel.com wrote: > > +static ssize_t skx_iio_mapping_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + struct pmu *pmu = dev_get_drvdata(dev); > > + struct intel_uncore_pmu *uncore_pmu = > > + container_of(pmu, struct intel_uncore_pmu, pmu); > > + > > + struct dev_ext_attribute *ea = > > + container_of(attr, struct dev_ext_attribute, attr); > > + long die = (long)ea->var; > > + > > + return sprintf(buf, "0000:%02x\n", skx_iio_stack(uncore_pmu, die)); > > If "0000:" is always the "prefix" of the output of this file, why have > it at all as you always know it is there? > > What is ever going to cause that to change? I think it's just to make it a complete PCI address. In theory it might be different on a complex multi node system with custom interconnect and multiple PCI segments, but that would need code changes too. This version of the patchkit only supports standard SKX systems at this point. -Andi