Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     Chris Healy <cphealy@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v7 4/9] crypto: caam - drop global context pointer and
 init_done
Thread-Topic: [PATCH v7 4/9] crypto: caam - drop global context pointer and
 init_done
Thread-Index: AQHV1TLT2rTrmTBv2U6pvLOb9zqi1Q==
Date:   Tue, 11 Feb 2020 18:53:41 +0000
Message-ID: <VI1PR0402MB34851436875DA6CB8524C92298180@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20200127165646.19806-1-andrew.smirnov@gmail.com>
 <20200127165646.19806-5-andrew.smirnov@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 56f65fb0-d8fb-4b37-2ac5-08d7af23b663
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2020 18:53:41.3134
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9QziBJaFkegC6XDevCZrLFp/2ZuIDdB2QCMCugz6pgenW4QyQmj+QtdGzZ/ewxyNBWiajBdIuGfAu4CQBdmG7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/27/2020 6:57 PM, Andrey Smirnov wrote:=0A=
> Leverage devres to get rid of code storing global context as well as=0A=
> init_done flag.=0A=
> =0A=
> Original code also has a circular deallocation dependency where=0A=
> unregister_algs() -> caam_rng_exit() -> caam_jr_free() chain would=0A=
> only happen if all of JRs were freed. Fix this by moving=0A=
I wouldn't call this a circular dependency.=0A=
=0A=
I think the discussion & patch here:=0A=
https://patchwork.kernel.org/patch/11140741/=0A=
https://lore.kernel.org/linux-crypto/VI1PR0402MB34859D108C03F3AB0F64EE6598B=
10@VI1PR0402MB3485.eurprd04.prod.outlook.com/=0A=
=0A=
describes more accurately the problem:=0A=
"The issue in caamrng is actually that caam/jr driver (jr.c) tries to call=
=0A=
caam_rng_exit() on the last available jr device.=0A=
Instead, caam_rng_exit() must be called on the same jr device that=0A=
was used during caam_rng_init()."=0A=
=0A=
> caam_rng_exit() outside of unregister_algs() and doing it specifically=0A=
> for JR that instantiated HWRNG.=0A=
> =0A=
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>=0A=
> Cc: Chris Healy <cphealy@gmail.com>=0A=
> Cc: Lucas Stach <l.stach@pengutronix.de>=0A=
> Cc: Horia Geant=E3 <horia.geanta@nxp.com>=0A=
> Cc: Herbert Xu <herbert@gondor.apana.org.au>=0A=
> Cc: Iuliana Prodan <iuliana.prodan@nxp.com>=0A=
> Cc: linux-crypto@vger.kernel.org=0A=
> Cc: linux-kernel@vger.kernel.org=0A=
> Cc: linux-imx@nxp.com=0A=
Current patch is similar with the one mentioned above and solves the proble=
m.=0A=
Thus, with rewording the commit message (and squashing patch 3/9)=0A=
you can add my=0A=
Reviewed-by: Horia Geant=E3 <horia.geanta@nxp.com>=0A=
=0A=
Thanks,=0A=
Horia=0A=
=0A=