Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5332793ybv; Tue, 11 Feb 2020 13:42:09 -0800 (PST) X-Google-Smtp-Source: APXvYqxji8udaTHunHQtxyuqRdZe0FED0vMYsBRCLPGM7gs241WmjBaJTY1DXppDVtpORLW+VrPT X-Received: by 2002:a9d:63d6:: with SMTP id e22mr153116otl.185.1581457329532; Tue, 11 Feb 2020 13:42:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581457329; cv=none; d=google.com; s=arc-20160816; b=c3qDINg+P2Jqa7lyAx+o5buvHQ8KLaBGytZikErnB+lWPj0JsYVux5CgSnSunKXMBO jDJ6Quc02UK2/O7F4BlO0gsHCh8R5y6w+jdZL0kS6edFAETEtGaaHDTNh11/yFCJCYkf 6k0A/wksnuB3WBOXtZAvYl+ZGJ/AsJwMTpNRdFRvE4Xv/y/4QdgQGhj8qEnmBC1YCabo 72XotMcmdFZPdeveUvm2TfU6aUd5WPQmgyI7lcuPn3E9Y+yfas3LC9B61lS/qFvuW6or MSJWJgOZ8Y0jPvNvyiQQaLfwmUdvL9f5gYyP9kGhpDvgylzxQn7gppldz4UhCB+l7wO9 RvZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=d79/juOKGQ3xhEKgN8cqkrkeeX6KR3FsfafPiPWnTjk=; b=gkHmFp8v12TTqwZ7MwURpttNkaujFeYw7r7eLoLQikSvuLg2AxmE4MlDeoDkwXOnrf vMjbExHz5cMHcJhacBRYDJNBperAcNHxCkaN4L3P1nK7B0PPu4zPcBiFsZByxJ106AXc 4/4TCdPawYi5paRYliOvj226lX/sEyn57EdKngdkTbHuICGMUMn7URStNdss7dR1PNR4 JUx+5kY3pdOAjRAgf/lxTMgSP+6Dn3Wu2iXDVBPUsuYfXEhzw+Fy09DOoFC30j4wxMbo VVlM0R60OaCLsaF0XdB5UOOL9RQs4x/CLeyTeGWWvV/fYR2K+kCa6WWiid+WVyDGiS6t VDSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=iKL3T3KT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j65si2386186otc.308.2020.02.11.13.41.57; Tue, 11 Feb 2020 13:42:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=iKL3T3KT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730911AbgBKUJW (ORCPT + 99 others); Tue, 11 Feb 2020 15:09:22 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:34229 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728068AbgBKUJW (ORCPT ); Tue, 11 Feb 2020 15:09:22 -0500 Received: by mail-oi1-f194.google.com with SMTP id l136so14072019oig.1 for ; Tue, 11 Feb 2020 12:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d79/juOKGQ3xhEKgN8cqkrkeeX6KR3FsfafPiPWnTjk=; b=iKL3T3KT/E0Iwsb3fnUfmhLupejJLrt0Xw5IOfw8B/SqKyHuAmgD6b5kRaiIeb6uQi 4hqOAy9ePuT7GdoTUwr87pkUzlBm0LRqEEFiWmTJS7vLwJwDvOy2UWIrGEpnJS5HNg6L UJ3OcYCcXDup4hmac0c8ZAtTXuIBB4C4CC3djbwDvtd6WU9keMA7joMyqQ4WttYi8EBN vrOINTqg3CqyMUDW8SXtRJMA5A2vJY60W9spolclj6hO3pOdiey4rg0CUIfOnXDULfGo s6RA3SPhR9ow2ObUxJ9XLAnHJ3VD73fdhMjBf6otQbBS3osn2sT48zUHMkQ908wokOCL r57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d79/juOKGQ3xhEKgN8cqkrkeeX6KR3FsfafPiPWnTjk=; b=O2zyuiaG+/HqCDQmns5XebljSSM4exLWtQ/uEFnZF2TaJ4aBGa5HOuEZCsELwKu+Kc UdaSCMT9wf6UDvZbmrqiqO3lCTTwISfYDVyHcA+mlys2/0GWh/jfuFu4dKbWYU/pA6wj hZYQdSrvzgvn855PhAk2YsXfWd2oyQ7LZ7Q99gNH6bjrRNBtE2TqLc+6OkT25D90k4LR RM6B5eeDLUSNQx9LjnNtfp3EVbuyyQGwMCRtII9cMJaWMQRARFeUV7xzwQ+CDxtRXKr9 Gj+q/uQjiPpus/x2asuoElcVEiKFHoowLCs6Kv27qbYA6G+t0dUgoIhrzlL2Irs2vKfi goWg== X-Gm-Message-State: APjAAAXamb0lKo6PA22NTzXvOP54YLRgyh0vsn362Btcki5+MnhGIaft G5PTapCwLhIPKHUsebm/EutenuXH1JSIu7OP1ffQkA== X-Received: by 2002:aca:ea43:: with SMTP id i64mr4107524oih.30.1581451761048; Tue, 11 Feb 2020 12:09:21 -0800 (PST) MIME-Version: 1.0 References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-6-drinkcat@chromium.org> In-Reply-To: From: Saravana Kannan Date: Tue, 11 Feb 2020 12:08:44 -0800 Message-ID: Subject: Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains To: Rob Herring Cc: Nicolas Boichat , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > +Saravana > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > > > When there is a single power domain per device, the core will > > ensure the power domain is switched on (so it is technically > > equivalent to having not power domain specified at all). > > > > However, when there are multiple domains, as in MT8183 Bifrost > > GPU, we need to handle them in driver code. > > > > Signed-off-by: Nicolas Boichat > > > > --- > > > > The downstream driver we use on chromeos-4.19 currently uses 2 > > additional devices in device tree to accomodate for this [1], but > > I believe this solution is cleaner. > > > > [1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/chromeos-4.19/drivers/gpu/arm/midgard/platform/mediatek/mali_kbase_runtime_pm.c#31 > > > > v4: > > - Match the exact power domain names as specified in the compatible > > struct, instead of just matching the number of power domains. > > [Review: Ulf Hansson] > > - Dropped print and reordered function [Review: Steven Price] > > - nits: Run through latest version of checkpatch: > > - Use WARN instead of BUG_ON. > > - Drop braces for single expression if block. > > v3: > > - Use the compatible matching data to specify the number of power > > domains. Note that setting 0 or 1 in num_pm_domains is equivalent > > as the core will handle these 2 cases in the exact same way > > (automatically, without driver intervention), and there should > > be no adverse consequence in this case (the concern is about > > switching on only some power domains and not others). > > > > drivers/gpu/drm/panfrost/panfrost_device.c | 97 ++++++++++++++++++++-- > > drivers/gpu/drm/panfrost/panfrost_device.h | 11 +++ > > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + > > 3 files changed, 102 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > > index 3720d50f6d9f965..8136babd3ba9935 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > > @@ -5,6 +5,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #include "panfrost_device.h" > > @@ -120,6 +121,79 @@ static void panfrost_regulator_fini(struct panfrost_device *pfdev) > > pfdev->regulators); > > } > > > > +static void panfrost_pm_domain_fini(struct panfrost_device *pfdev) > > +{ > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > + if (!pfdev->pm_domain_devs[i]) > > + break; > > + > > + if (pfdev->pm_domain_links[i]) > > + device_link_del(pfdev->pm_domain_links[i]); > > + > > + dev_pm_domain_detach(pfdev->pm_domain_devs[i], true); > > + } > > +} > > + > > +static int panfrost_pm_domain_init(struct panfrost_device *pfdev) > > +{ > > + int err; > > + int i, num_domains; > > + > > + num_domains = of_count_phandle_with_args(pfdev->dev->of_node, > > + "power-domains", > > + "#power-domain-cells"); > > + > > + /* > > + * Single domain is handled by the core, and, if only a single power > > + * the power domain is requested, the property is optional. > > + */ > > + if (num_domains < 2 && pfdev->comp->num_pm_domains < 2) > > + return 0; > > + > > + if (num_domains != pfdev->comp->num_pm_domains) { > > + dev_err(pfdev->dev, > > + "Incorrect number of power domains: %d provided, %d needed\n", > > + num_domains, pfdev->comp->num_pm_domains); > > + return -EINVAL; > > + } > > + > > + if (WARN(num_domains > ARRAY_SIZE(pfdev->pm_domain_devs), > > + "Too many supplies in compatible structure.\n")) > > + return -EINVAL; > > + > > + for (i = 0; i < num_domains; i++) { > > + pfdev->pm_domain_devs[i] = > > + dev_pm_domain_attach_by_name(pfdev->dev, > > + pfdev->comp->pm_domain_names[i]); > > + if (IS_ERR_OR_NULL(pfdev->pm_domain_devs[i])) { > > + err = PTR_ERR(pfdev->pm_domain_devs[i]) ? : -ENODATA; > > + pfdev->pm_domain_devs[i] = NULL; > > + dev_err(pfdev->dev, > > + "failed to get pm-domain %s(%d): %d\n", > > + pfdev->comp->pm_domain_names[i], i, err); > > + goto err; > > + } > > + > > + pfdev->pm_domain_links[i] = device_link_add(pfdev->dev, > > + pfdev->pm_domain_devs[i], DL_FLAG_PM_RUNTIME | > > + DL_FLAG_STATELESS | DL_FLAG_RPM_ACTIVE); > > We're in the process of adding device links based on DT properties. > Shouldn't we add power domains to that? See drivers/of/property.c for > what's handled. Rob, drivers/of/property.c doesn't enable the RPM_ACTIVE AND PM_RUNTIME flags. Wanted to start off conservative. But adding command line ops to change the default flags shouldn't be difficult. But before I do that, I want to change of_devlink to fw_devlink=. May be I can extend that to "disabled, permissive, suspend, runtime". Nicholas, And the adding and removing of device links for power domains will be a 2 line change. I've been meaning to add a few more bindings like hwspinlocks and pinctrl. I can roll power domains support into that if you want. -Saravana