Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Feb 2020 10:31:33 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v1] printk: Declare log_wait as external variable
Message-ID: <20200212013133.GB13208@google.com>
References: <20200203131528.52825-1-andriy.shevchenko@linux.intel.com>
 <20200211124317.x5erhl7kvxj2nq6a@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200211124317.x5erhl7kvxj2nq6a@pathway.suse.cz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (20/02/11 13:43), Petr Mladek wrote:
>
> Even better solution might be to move fs/proc/kmsg.c to
> kernel/printk/proc_kmsg.c and declare printk_log_wait only
> in kernel/printk/internal.h. I think that this is what
> Sergey suggested.

Yes, right.

> Another great thing would be to extract devkmsg stuff from
> kernel/printk/printk.c and put it into kernel/printk/dev_kmsg.c.

Yeah, can do, I would still prefer proc_kmsg to "move in".
Either both can live in printk.c (won't make it much worse),
or in kernel/printk/dev_kmsg.c and kernel/printk/proc_kmsg.c

I can take a look at dev_ksmg.c/proc_kmsg.c option, unless
someone else wants to spend their time on this.

	-ss